Add graphics effect methods to IStageHandler

Author: adazem009

include/scratchcpp/istagehandler.h

@@ -28,6 +28,15 @@ class LIBSCRATCHCPP_EXPORT IStageHandler
 
         /*! Called when the video transparency changes. */
         virtual void onVideoTransparencyChanged(int videoTransparency) = 0;
+
+        /*!
+         * Called when the value of the given graphics effect changes.
+         * \note This method isn't called when all effects are cleared, use onGraphicsEffectsCleared() for this.
+         */
+        virtual void onGraphicsEffectChanged(IGraphicsEffect *effect, double value) = 0;
+
+        /*! Called when all graphics effects are cleared. */
+        virtual void onGraphicsEffectsCleared() = 0;
 };
 
 } // namespace libscratchcpp

src/scratch/stage.cpp

@@ -133,6 +133,9 @@ void Stage::setGraphicsEffectValue(IGraphicsEffect *effect, double value)
 
     if (eng)
         eng->requestRedraw();
+
+    if (impl->iface)
+        impl->iface->onGraphicsEffectChanged(effect, value);
 }
 
 /*! Overrides Target#clearGraphicsEffects(). */
@@ -143,4 +146,7 @@ void Stage::clearGraphicsEffects()
 
     if (eng)
         eng->requestRedraw();
+
+    if (impl->iface)
+        impl->iface->onGraphicsEffectsCleared();
 }

test/mocks/stagehandlermock.h

@@ -15,4 +15,6 @@ class StageHandlerMock : public IStageHandler
         MOCK_METHOD(void, onTempoChanged, (int), (override));
         MOCK_METHOD(void, onVideoStateChanged, (Stage::VideoState), (override));
         MOCK_METHOD(void, onVideoTransparencyChanged, (int), (override));
+        MOCK_METHOD(void, onGraphicsEffectChanged, (IGraphicsEffect *, double), (override));
+        MOCK_METHOD(void, onGraphicsEffectsCleared, (), (override));
 };

test/target_interfaces/istagehandler_test.cpp

@@ -1,6 +1,8 @@
 #include <scratchcpp/stage.h>
 #include <scratchcpp/costume.h>
 #include <stagehandlermock.h>
+#include <enginemock.h>
+#include <graphicseffectmock.h>
 
 #include "../common.h"
 
@@ -13,10 +15,12 @@ class IStageHandlerTest : public testing::Test
         {
             EXPECT_CALL(m_handler, init(&m_stage)).Times(1);
             m_stage.setInterface(&m_handler);
+            m_stage.setEngine(&m_engine);
         }
 
         Stage m_stage;
         StageHandlerMock m_handler;
+        EngineMock m_engine;
 };
 
 TEST_F(IStageHandlerTest, Tempo)
@@ -42,8 +46,23 @@ TEST_F(IStageHandlerTest, Costume)
     m_stage.addCostume(costume2);
 
     EXPECT_CALL(m_handler, onCostumeChanged(costume1.get()));
+    EXPECT_CALL(m_engine, requestRedraw());
     m_stage.setCostumeIndex(0);
 
     EXPECT_CALL(m_handler, onCostumeChanged(costume2.get()));
+    EXPECT_CALL(m_engine, requestRedraw());
     m_stage.setCostumeIndex(1);
 }
+
+TEST_F(IStageHandlerTest, GraphicsEffects)
+{
+    GraphicsEffectMock effect;
+
+    EXPECT_CALL(m_handler, onGraphicsEffectChanged(&effect, 16.7));
+    EXPECT_CALL(m_engine, requestRedraw());
+    m_stage.setGraphicsEffectValue(&effect, 16.7);
+
+    EXPECT_CALL(m_handler, onGraphicsEffectsCleared());
+    EXPECT_CALL(m_engine, requestRedraw());
+    m_stage.clearGraphicsEffects();
+}