Skip to content

Commit 3486d03

Browse files
committed
Use a null block in looks blocks test
1 parent b1a1b02 commit 3486d03

File tree

1 file changed

+15
-18
lines changed

1 file changed

+15
-18
lines changed

test/blocks/looks_blocks_test.cpp

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@ class LooksBlocksTest : public testing::Test
3030
// For any looks block
3131
std::shared_ptr<Block> createLooksBlock(const std::string &id, const std::string &opcode) const { return std::make_shared<Block>(id, opcode); }
3232

33+
std::shared_ptr<Block> createNullBlock(const std::string &id)
34+
{
35+
std::shared_ptr<Block> block = std::make_shared<Block>(id, "");
36+
BlockComp func = [](Compiler *compiler) { compiler->addInstruction(vm::OP_NULL); };
37+
block->setCompileFunction(func);
38+
39+
return block;
40+
}
41+
3342
void addValueInput(std::shared_ptr<Block> block, const std::string &name, LooksBlocks::Inputs id, const Value &value) const
3443
{
3544
auto input = std::make_shared<Input>(name, Input::Type::Shadow);
@@ -363,11 +372,9 @@ TEST_F(LooksBlocksTest, SwitchCostumeTo)
363372
auto block10 = std::make_shared<Block>("f", "looks_switchcostumeto");
364373
addDropdownInput(block10, "COSTUME", LooksBlocks::COSTUME, "previous costume");
365374

366-
// switch costume to (join "" "")
367-
auto joinBlock = std::make_shared<Block>("h", "operator_join");
368-
joinBlock->setCompileFunction(&OperatorBlocks::compileJoin);
375+
// switch costume to (null block)
369376
auto block11 = std::make_shared<Block>("g", "looks_switchcostumeto");
370-
addDropdownInput(block11, "COSTUME", LooksBlocks::COSTUME, "", joinBlock);
377+
addDropdownInput(block11, "COSTUME", LooksBlocks::COSTUME, "", createNullBlock("h"));
371378

372379
compiler.init();
373380

@@ -473,8 +480,6 @@ TEST_F(LooksBlocksTest, SwitchCostumeTo)
473480
vm::OP_EXEC,
474481
0,
475482
vm::OP_NULL,
476-
vm::OP_NULL,
477-
vm::OP_STR_CONCAT,
478483
vm::OP_EXEC,
479484
3,
480485
vm::OP_HALT }));
@@ -785,11 +790,9 @@ TEST_F(LooksBlocksTest, SwitchBackdropTo)
785790
auto block12 = std::make_shared<Block>("h", "looks_switchbackdropto");
786791
addDropdownInput(block12, "BACKDROP", LooksBlocks::BACKDROP, "random backdrop");
787792

788-
// switch backdrop to (join "" "")
789-
auto joinBlock = std::make_shared<Block>("j", "operator_join");
790-
joinBlock->setCompileFunction(&OperatorBlocks::compileJoin);
793+
// switch backdrop to (null block)
791794
auto block13 = std::make_shared<Block>("i", "looks_switchbackdropto");
792-
addDropdownInput(block13, "BACKDROP", LooksBlocks::BACKDROP, "", joinBlock);
795+
addDropdownInput(block13, "BACKDROP", LooksBlocks::BACKDROP, "", createNullBlock("j"));
793796

794797
compiler.init();
795798

@@ -925,8 +928,6 @@ TEST_F(LooksBlocksTest, SwitchBackdropTo)
925928
vm::OP_EXEC,
926929
0,
927930
vm::OP_NULL,
928-
vm::OP_NULL,
929-
vm::OP_STR_CONCAT,
930931
vm::OP_EXEC,
931932
4,
932933
vm::OP_HALT }));
@@ -1196,11 +1197,9 @@ TEST_F(LooksBlocksTest, SwitchBackdropToAndWait)
11961197
auto block12 = std::make_shared<Block>("h", "looks_switchbackdroptoandwait");
11971198
addDropdownInput(block12, "BACKDROP", LooksBlocks::BACKDROP, "random backdrop");
11981199

1199-
// switch backdrop to (join "" "") and wait
1200-
auto joinBlock = std::make_shared<Block>("j", "operator_join");
1201-
joinBlock->setCompileFunction(&OperatorBlocks::compileJoin);
1200+
// switch backdrop to (null block) and wait
12021201
auto block13 = std::make_shared<Block>("i", "looks_switchbackdroptoandwait");
1203-
addDropdownInput(block13, "BACKDROP", LooksBlocks::BACKDROP, "", joinBlock);
1202+
addDropdownInput(block13, "BACKDROP", LooksBlocks::BACKDROP, "", createNullBlock("j"));
12041203

12051204
compiler.init();
12061205

@@ -1376,8 +1375,6 @@ TEST_F(LooksBlocksTest, SwitchBackdropToAndWait)
13761375
vm::OP_EXEC,
13771376
5,
13781377
vm::OP_NULL,
1379-
vm::OP_NULL,
1380-
vm::OP_STR_CONCAT,
13811378
vm::OP_EXEC,
13821379
4,
13831380
vm::OP_EXEC,

0 commit comments

Comments
 (0)