Add support for unknown function return type

Author: adazem009

src/engine/internal/llvm/instructions/functions.cpp

@@ -46,15 +46,19 @@ LLVMInstruction *Functions::buildFunctionCall(LLVMInstruction *ins)
 
     // Args
     for (auto &arg : ins->args) {
-        types.push_back(m_utils.getType(arg.first));
+        types.push_back(m_utils.getType(arg.first, false));
         args.push_back(m_utils.castValue(arg.second, arg.first));
     }
 
-    llvm::Type *retType = m_utils.getType(ins->functionReturnReg ? ins->functionReturnReg->type() : Compiler::StaticType::Void);
+    llvm::Type *retType = m_utils.getType(ins->functionReturnReg ? ins->functionReturnReg->type() : Compiler::StaticType::Void, true);
     llvm::Value *ret = m_builder.CreateCall(m_utils.functions().resolveFunction(ins->functionName, llvm::FunctionType::get(retType, types, false)), args);
 
     if (ins->functionReturnReg) {
-        ins->functionReturnReg->value = ret;
+        if (ins->functionReturnReg->type() == Compiler::StaticType::Unknown) {
+            ins->functionReturnReg->value = m_utils.addAlloca(retType);
+            m_builder.CreateStore(ret, ins->functionReturnReg->value);
+        } else
+            ins->functionReturnReg->value = ret;
 
         if (ins->functionReturnReg->type() == Compiler::StaticType::String)
             m_utils.freeStringLater(ins->functionReturnReg->value);

src/engine/internal/llvm/llvmbuildutils.cpp

@@ -496,7 +496,7 @@ llvm::Value *LLVMBuildUtils::castValue(LLVMRegister *reg, Compiler::StaticType t
     }
 }
 
-llvm::Type *LLVMBuildUtils::getType(Compiler::StaticType type)
+llvm::Type *LLVMBuildUtils::getType(Compiler::StaticType type, bool isReturnType)
 {
     switch (type) {
         case Compiler::StaticType::Void:
@@ -515,7 +515,10 @@ llvm::Type *LLVMBuildUtils::getType(Compiler::StaticType type)
             return m_builder.getVoidTy()->getPointerTo();
 
         case Compiler::StaticType::Unknown:
-            return m_valueDataType->getPointerTo();
+            if (isReturnType)
+                return m_valueDataType;
+            else
+                return m_valueDataType->getPointerTo();
 
         default:
             assert(false);

src/engine/internal/llvm/llvmbuildutils.h

@@ -80,7 +80,7 @@ class LLVMBuildUtils
 
         llvm::Value *addAlloca(llvm::Type *type);
         llvm::Value *castValue(LLVMRegister *reg, Compiler::StaticType targetType);
-        llvm::Type *getType(Compiler::StaticType type);
+        llvm::Type *getType(Compiler::StaticType type, bool isReturnType);
         llvm::Value *isNaN(llvm::Value *num);
         llvm::Value *removeNaN(llvm::Value *num);
 

src/engine/internal/llvm/llvmcodebuilder.cpp

@@ -100,7 +100,10 @@ CompilerValue *LLVMCodeBuilder::addFunctionCall(const std::string &functionName,
 
     if (returnType != Compiler::StaticType::Void) {
         auto reg = std::make_shared<LLVMRegister>(returnType);
-        reg->isRawValue = true;
+
+        if (returnType != Compiler::StaticType::Unknown)
+            reg->isRawValue = true;
+
         ins->functionReturnReg = reg.get();
         return addReg(reg, ins);
     }

test/llvm/llvmcodebuilder_test.cpp

@@ -3301,3 +3301,28 @@ TEST_F(LLVMCodeBuilderTest, Reporters)
     ASSERT_EQ(value_toPointer(&ret), &pointee);
     value_free(&ret);
 }
+
+TEST_F(LLVMCodeBuilderTest, UnknownTypeReporter)
+{
+    Sprite sprite;
+    auto var = std::make_shared<Variable>("", "");
+    var->setValue("Hello world!");
+    sprite.addVariable(var);
+
+    LLVMCodeBuilder *builder = m_utils.createReporterBuilder(&sprite);
+
+    CompilerValue *num = builder->addConstValue(5.2);
+    builder->addFunctionCall("test_const_unknown", Compiler::StaticType::Unknown, { Compiler::StaticType::Unknown }, { num });
+
+    auto code = builder->build();
+
+    Script script(&sprite, nullptr, nullptr);
+    script.setCode(code);
+    Thread thread1(&sprite, nullptr, &script);
+    auto ctx = code->createExecutionContext(&thread1);
+
+    ValueData ret = code->runReporter(ctx.get());
+    ASSERT_TRUE(value_isNumber(&ret));
+    ASSERT_EQ(value_toDouble(&ret), 5.2);
+    value_free(&ret);
+}

test/llvm/testfunctions.cpp

@@ -139,6 +139,14 @@ extern "C"
         return ret;
     }
 
+    ValueData test_const_unknown(const ValueData *v)
+    {
+        ValueData ret;
+        value_init(&ret);
+        value_assign_copy(&ret, v);
+        return ret;
+    }
+
     const void *test_const_pointer(const void *v)
     {
         return v;