Skip to content

Commit 37640d7

Browse files
committed
Remove IEngine to Engine casts from Compiler test
1 parent dd1ea3a commit 37640d7

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

test/compiler/compiler_test.cpp

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,10 @@ TEST_F(CompilerTest, EmptyProject)
105105
ProjectPrivate p("empty_project.sb3", ScratchVersion::Scratch3);
106106
ASSERT_TRUE(p.load());
107107
auto engine = p.engine;
108-
// TODO: Remove the cast
109-
ASSERT_EQ(std::static_pointer_cast<Engine>(engine)->targets().size(), 1);
108+
ASSERT_EQ(engine->targets().size(), 1);
110109
ASSERT_EQ(engine->extensions().size(), 0);
111110
ASSERT_EQ(engine->broadcasts().size(), 0);
112-
// TODO: Remove the IEngine to Engine cast
113-
Stage *stage = dynamic_cast<Stage *>(std::static_pointer_cast<Engine>(engine)->targetAt(0));
111+
Stage *stage = dynamic_cast<Stage *>(engine->targetAt(0));
114112
ASSERT_EQ(stage->blocks().size(), 0);
115113
}
116114

@@ -119,15 +117,13 @@ TEST_F(CompilerTest, ResolveIds)
119117
ProjectPrivate p("resolve_id_test.sb3", ScratchVersion::Scratch3);
120118
ASSERT_TRUE(p.load());
121119
auto engine = p.engine;
122-
// TODO: Remove the cast
123-
ASSERT_EQ(std::static_pointer_cast<Engine>(engine)->targets().size(), 2);
120+
ASSERT_EQ(engine->targets().size(), 2);
124121
ASSERT_EQ(engine->extensions().size(), 0);
125122
ASSERT_EQ(engine->broadcasts().size(), 1);
126123

127124
// Stage
128-
// TODO: Remove the IEngine to Engine casts
129-
ASSERT_NE(std::static_pointer_cast<Engine>(engine)->findTarget("Stage"), -1);
130-
Stage *stage = dynamic_cast<Stage *>(std::static_pointer_cast<Engine>(engine)->targetAt(std::static_pointer_cast<Engine>(engine)->findTarget("Stage")));
125+
ASSERT_NE(engine->findTarget("Stage"), -1);
126+
Stage *stage = dynamic_cast<Stage *>(engine->targetAt(engine->findTarget("Stage")));
131127
ASSERT_TRUE(stage);
132128
ASSERT_EQ(stage->blocks().size(), 2);
133129
auto block = stage->greenFlagBlocks().at(0);
@@ -145,9 +141,8 @@ TEST_F(CompilerTest, ResolveIds)
145141
ASSERT_FALSE(block->next());
146142

147143
// Sprite1
148-
// TODO: Remove the IEngine to Engine casts
149-
ASSERT_NE(std::static_pointer_cast<Engine>(engine)->findTarget("Sprite1"), -1);
150-
Sprite *sprite1 = dynamic_cast<Sprite *>(std::static_pointer_cast<Engine>(engine)->targetAt(std::static_pointer_cast<Engine>(engine)->findTarget("Sprite1")));
144+
ASSERT_NE(engine->findTarget("Sprite1"), -1);
145+
Sprite *sprite1 = dynamic_cast<Sprite *>(engine->targetAt(engine->findTarget("Sprite1")));
151146
ASSERT_TRUE(sprite1);
152147
ASSERT_EQ(sprite1->blocks().size(), 5);
153148
block = sprite1->greenFlagBlocks().at(0);

0 commit comments

Comments
 (0)