Revert "Add string_pool_clear_thread() function"

This reverts commit 1d3c37d.

Author: adazem009

src/scratch/string_pool.cpp

@@ -10,8 +10,6 @@
 #include <cassert>
 #include <algorithm>
 
-#include "string_pool_p.h"
-
 namespace libscratchcpp
 {
 
@@ -77,26 +75,18 @@ void string_pool_add_thread(Thread *thread)
 }
 
 void string_pool_remove_thread(Thread *thread)
-{
-    string_pool_clear_thread(thread);
-    threadStrings.erase(thread);
-
-    if (currentThread == thread)
-        currentThread = nullptr;
-}
-
-void string_pool_clear_thread(Thread *thread)
 {
     // Free all strings in the thread (garbage collection)
     assert(threadStrings.find(thread) != threadStrings.cend());
     auto &strings = threadStrings[thread];
 
-    for (StringPtr *str : strings) {
-        assert(std::find_if(freeStrings.begin(), freeStrings.end(), [str](const std::pair<size_t, StringPtr *> &p) { return p.second == str; }) == freeStrings.end());
+    for (StringPtr *str : strings)
         freeStrings.insert(std::pair<size_t, StringPtr *>(str->allocatedSize, str));
-    }
 
-    strings.clear();
+    threadStrings.erase(thread);
+
+    if (currentThread == thread)
+        currentThread = nullptr;
 }
 
 void string_pool_set_thread(Thread *thread)

src/scratch/string_pool_p.h

@@ -7,7 +7,6 @@ class Thread;
 
 void string_pool_add_thread(Thread *thread);
 void string_pool_remove_thread(Thread *thread);
-void string_pool_clear_thread(Thread *thread);
 void string_pool_set_thread(Thread *thread);
 
 } // namespace libscratchcpp