Engine: Add missing references

Author: adazem009

src/engine/engine.cpp

@@ -322,7 +322,7 @@ std::shared_ptr<IBlockSection> Engine::blockSection(const std::string &opcode) c
 }
 
 /*! Returns the list of broadcasts. */
-std::vector<std::shared_ptr<Broadcast>> Engine::broadcasts() const
+const std::vector<std::shared_ptr<Broadcast>> &Engine::broadcasts() const
 {
     return m_broadcasts;
 }
@@ -375,7 +375,7 @@ void libscratchcpp::Engine::addBroadcastScript(std::shared_ptr<Block> whenReceiv
 }
 
 /*! Returns the list of targets. */
-std::vector<std::shared_ptr<Target>> Engine::targets() const
+const std::vector<std::shared_ptr<Target>> &Engine::targets() const
 {
     return m_targets;
 }
@@ -414,7 +414,7 @@ int Engine::findTarget(const std::string &targetName) const
 }
 
 /*! Returns the list of extension names. */
-std::vector<std::string> Engine::extensions() const
+const std::vector<std::string> &Engine::extensions() const
 {
     return m_extensions;
 }
@@ -445,7 +445,7 @@ const std::unordered_map<std::shared_ptr<Block>, std::shared_ptr<Script>> &Engin
 }
 
 /*! Returns the block with the given ID. */
-std::shared_ptr<Block> Engine::getBlock(std::string id)
+std::shared_ptr<Block> Engine::getBlock(const std::string &id)
 {
     if (id.empty())
         return nullptr;
@@ -460,7 +460,7 @@ std::shared_ptr<Block> Engine::getBlock(std::string id)
 }
 
 /*! Returns the variable with the given ID. */
-std::shared_ptr<Variable> Engine::getVariable(std::string id)
+std::shared_ptr<Variable> Engine::getVariable(const std::string &id)
 {
     if (id.empty())
         return nullptr;
@@ -475,7 +475,7 @@ std::shared_ptr<Variable> Engine::getVariable(std::string id)
 }
 
 /*! Returns the Scratch list with the given ID. */
-std::shared_ptr<List> Engine::getList(std::string id)
+std::shared_ptr<List> Engine::getList(const std::string &id)
 {
     if (id.empty())
         return nullptr;
@@ -490,7 +490,7 @@ std::shared_ptr<List> Engine::getList(std::string id)
 }
 
 /*! Returns the broadcast with the given ID. */
-std::shared_ptr<Broadcast> Engine::getBroadcast(std::string id)
+std::shared_ptr<Broadcast> Engine::getBroadcast(const std::string &id)
 {
     if (id.empty())
         return nullptr;
@@ -503,7 +503,7 @@ std::shared_ptr<Broadcast> Engine::getBroadcast(std::string id)
 }
 
 /*! Returns the entity with the given ID. \see IEntity */
-std::shared_ptr<IEntity> Engine::getEntity(std::string id)
+std::shared_ptr<IEntity> Engine::getEntity(const std::string &id)
 {
     // Blocks
     auto block = getBlock(id);

src/engine/engine.h

@@ -51,30 +51,30 @@ class LIBSCRATCHCPP_EXPORT Engine
         unsigned int functionIndex(BlockFunc f);
         std::shared_ptr<IBlockSection> blockSection(const std::string &opcode) const;
 
-        std::vector<std::shared_ptr<Broadcast>> broadcasts() const;
+        const std::vector<std::shared_ptr<Broadcast>> &broadcasts() const;
         void setBroadcasts(const std::vector<std::shared_ptr<Broadcast>> &broadcasts);
         std::shared_ptr<Broadcast> broadcastAt(int index) const;
         int findBroadcast(const std::string &broadcastName) const;
         int findBroadcastById(const std::string &broadcastId) const;
 
         void addBroadcastScript(std::shared_ptr<Block> whenReceivedBlock, std::shared_ptr<Broadcast> broadcast);
 
-        std::vector<std::shared_ptr<Target>> targets() const;
+        const std::vector<std::shared_ptr<Target>> &targets() const;
         void setTargets(const std::vector<std::shared_ptr<Target>> &newTargets);
         Target *targetAt(int index) const;
         int findTarget(const std::string &targetName) const;
 
-        std::vector<std::string> extensions() const;
+        const std::vector<std::string> &extensions() const;
         void setExtensions(const std::vector<std::string> &newExtensions);
 
         const std::unordered_map<std::shared_ptr<Block>, std::shared_ptr<Script>> &scripts() const;
 
     private:
-        std::shared_ptr<Block> getBlock(std::string id);
-        std::shared_ptr<Variable> getVariable(std::string id);
-        std::shared_ptr<List> getList(std::string id);
-        std::shared_ptr<Broadcast> getBroadcast(std::string id);
-        std::shared_ptr<IEntity> getEntity(std::string id);
+        std::shared_ptr<Block> getBlock(const std::string &id);
+        std::shared_ptr<Variable> getVariable(const std::string &id);
+        std::shared_ptr<List> getList(const std::string &id);
+        std::shared_ptr<Broadcast> getBroadcast(const std::string &id);
+        std::shared_ptr<IEntity> getEntity(const std::string &id);
         std::vector<std::shared_ptr<IBlockSection>> m_sections;
         std::vector<std::shared_ptr<Target>> m_targets;
         std::vector<std::shared_ptr<Broadcast>> m_broadcasts;