Implement sound_changeeffectby block

Author: adazem009

src/blocks/soundblocks.cpp

@@ -35,6 +35,7 @@ void SoundBlocks::registerBlocks(IEngine *engine)
     engine->addCompileFunction(this, "sound_playuntildone", &compilePlayUntilDone);
     engine->addCompileFunction(this, "sound_stopallsounds", &compileStopAllSounds);
     engine->addCompileFunction(this, "sound_seteffectto", &compileSetEffectTo);
+    engine->addCompileFunction(this, "sound_changeeffectby", &compileChangeEffectBy);
 }
 
 void SoundBlocks::onInit(IEngine *engine)
@@ -100,6 +101,26 @@ CompilerValue *SoundBlocks::compileSetEffectTo(Compiler *compiler)
     return nullptr;
 }
 
+CompilerValue *SoundBlocks::compileChangeEffectBy(Compiler *compiler)
+{
+    Field *field = compiler->field("EFFECT");
+
+    if (!field)
+        return nullptr;
+
+    const std::string &option = field->value().toString();
+
+    if (option == "PITCH") {
+        auto value = compiler->addInput("VALUE");
+        compiler->addTargetFunctionCall("sound_change_pitch_effect", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { value });
+    } else if (option == "PAN") {
+        auto value = compiler->addInput("VALUE");
+        compiler->addTargetFunctionCall("sound_change_pan_effect", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { value });
+    }
+
+    return nullptr;
+}
+
 int sound_wrap_clamp_index(Target *target, int index)
 {
     const long soundCount = target->sounds().size();
@@ -179,3 +200,13 @@ extern "C" void sound_set_pan_effect(Target *target, double value)
 {
     target->setSoundEffectValue(Sound::Effect::Pan, value);
 }
+
+extern "C" void sound_change_pitch_effect(Target *target, double value)
+{
+    target->setSoundEffectValue(Sound::Effect::Pitch, target->soundEffectValue(Sound::Effect::Pitch) + value);
+}
+
+extern "C" void sound_change_pan_effect(Target *target, double value)
+{
+    target->setSoundEffectValue(Sound::Effect::Pan, target->soundEffectValue(Sound::Effect::Pan) + value);
+}

src/blocks/soundblocks.h

@@ -24,6 +24,7 @@ class SoundBlocks : public IExtension
         static CompilerValue *compilePlayUntilDone(Compiler *compiler);
         static CompilerValue *compileStopAllSounds(Compiler *compiler);
         static CompilerValue *compileSetEffectTo(Compiler *compiler);
+        static CompilerValue *compileChangeEffectBy(Compiler *compiler);
 };
 
 } // namespace libscratchcpp

test/blocks/sound_blocks_test.cpp

@@ -946,3 +946,66 @@ TEST_F(SoundBlocksTest, SetEffectTo_Pan)
     EXPECT_CALL(*target, setSoundEffectValue(Sound::Effect::Pan, -23.8));
     thread.run();
 }
+
+TEST_F(SoundBlocksTest, ChangeEffectBy_Invalid)
+{
+    auto target = std::make_shared<TargetMock>();
+
+    ScriptBuilder builder(m_extension.get(), m_engine, target);
+    builder.addBlock("sound_changeeffectby");
+    builder.addDropdownField("EFFECT", "abc");
+    builder.addValueInput("VALUE", 1);
+    auto block = builder.currentBlock();
+
+    Compiler compiler(&m_engineMock, target.get());
+    auto code = compiler.compile(block);
+    Script script(target.get(), block, &m_engineMock);
+    script.setCode(code);
+    Thread thread(target.get(), &m_engineMock, &script);
+
+    EXPECT_CALL(*target, soundEffectValue).Times(0);
+    EXPECT_CALL(*target, setSoundEffectValue).Times(0);
+    thread.run();
+}
+
+TEST_F(SoundBlocksTest, ChangeEffectBy_Pitch)
+{
+    auto target = std::make_shared<TargetMock>();
+
+    ScriptBuilder builder(m_extension.get(), m_engine, target);
+    builder.addBlock("sound_changeeffectby");
+    builder.addDropdownField("EFFECT", "PITCH");
+    builder.addValueInput("VALUE", 75.2);
+    auto block = builder.currentBlock();
+
+    Compiler compiler(&m_engineMock, target.get());
+    auto code = compiler.compile(block);
+    Script script(target.get(), block, &m_engineMock);
+    script.setCode(code);
+    Thread thread(target.get(), &m_engineMock, &script);
+
+    EXPECT_CALL(*target, soundEffectValue(Sound::Effect::Pitch)).WillOnce(Return(-28.6));
+    EXPECT_CALL(*target, setSoundEffectValue(Sound::Effect::Pitch, 46.6));
+    thread.run();
+}
+
+TEST_F(SoundBlocksTest, ChangeEffectBy_Pan)
+{
+    auto target = std::make_shared<TargetMock>();
+
+    ScriptBuilder builder(m_extension.get(), m_engine, target);
+    builder.addBlock("sound_changeeffectby");
+    builder.addDropdownField("EFFECT", "PAN");
+    builder.addValueInput("VALUE", -23.8);
+    auto block = builder.currentBlock();
+
+    Compiler compiler(&m_engineMock, target.get());
+    auto code = compiler.compile(block);
+    Script script(target.get(), block, &m_engineMock);
+    script.setCode(code);
+    Thread thread(target.get(), &m_engineMock, &script);
+
+    EXPECT_CALL(*target, soundEffectValue(Sound::Effect::Pan)).WillOnce(Return(12.5));
+    EXPECT_CALL(*target, setSoundEffectValue(Sound::Effect::Pan, -11.3));
+    thread.run();
+}