Use raw pointers for loop var/list write instructions

Author: adazem009

src/engine/internal/llvm/llvmcodebuilder.cpp

@@ -1742,7 +1742,7 @@ void LLVMCodeBuilder::createVariableWrite(Variable *variable, CompilerValue *val
 
     if (m_loopScope >= 0) {
         auto scope = m_loopScopes[m_loopScope];
-        m_variablePtrs[variable].loopVariableWrites[scope.get()].push_back(m_instructionList.back());
+        m_variablePtrs[variable].loopVariableWrites[scope.get()].push_back(m_instructions.last());
     }
 
     m_variableInstructions.push_back(m_instructions.last());
@@ -1779,7 +1779,7 @@ void LLVMCodeBuilder::createListAppend(List *list, CompilerValue *item)
 
     if (m_loopScope >= 0) {
         auto scope = m_loopScopes[m_loopScope];
-        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructionList.back());
+        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructions.last());
     }
 
     m_listInstructions.push_back(m_instructions.last());
@@ -1796,7 +1796,7 @@ void LLVMCodeBuilder::createListInsert(List *list, CompilerValue *index, Compile
 
     if (m_loopScope >= 0) {
         auto scope = m_loopScopes[m_loopScope];
-        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructionList.back());
+        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructions.last());
     }
 
     m_listInstructions.push_back(m_instructions.last());
@@ -1813,7 +1813,7 @@ void LLVMCodeBuilder::createListReplace(List *list, CompilerValue *index, Compil
 
     if (m_loopScope >= 0) {
         auto scope = m_loopScopes[m_loopScope];
-        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructionList.back());
+        m_listPtrs[list].loopListWrites[scope.get()].push_back(m_instructions.last());
     }
 
     m_listInstructions.push_back(m_instructions.last());
@@ -2656,7 +2656,7 @@ bool LLVMCodeBuilder::isVarOrListTypeSafe(LLVMInstruction *ins, Compiler::Static
             const auto &writes = it->second;
 
             for (auto w : writes)
-                lastWrites.push_back(w.get());
+                lastWrites.push_back(w);
         }
 
         if (checkScope->childScopes.empty())

src/engine/internal/llvm/llvmlistptr.h

@@ -28,7 +28,7 @@ struct LLVMListPtr
         Compiler::StaticType type = Compiler::StaticType::Unknown;
 
         // Used in build phase to check the type safety of lists in loops
-        std::unordered_map<LLVMLoopScope *, std::vector<std::shared_ptr<LLVMInstruction>>> loopListWrites; // loop scope, write instructions
+        std::unordered_map<LLVMLoopScope *, std::vector<LLVMInstruction *>> loopListWrites; // loop scope, write instructions
 };
 
 } // namespace libscratchcpp

src/engine/internal/llvm/llvmvariableptr.h

@@ -27,7 +27,7 @@ struct LLVMVariablePtr
         bool changed = false;
 
         // Used in build phase to check the type safety of variables in loops
-        std::unordered_map<LLVMLoopScope *, std::vector<std::shared_ptr<LLVMInstruction>>> loopVariableWrites; // loop scope, write instructions
+        std::unordered_map<LLVMLoopScope *, std::vector<LLVMInstruction *>> loopVariableWrites; // loop scope, write instructions
 };
 
 } // namespace libscratchcpp