LLVMCodeBuilder: Use unsigned integer in repeat loop

Author: adazem009

src/dev/engine/internal/llvm/llvmcodebuilder.cpp

@@ -796,7 +796,7 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()
                 m_builder.SetInsertPoint(roundBranch);
                 llvm::Function *roundFunc = llvm::Intrinsic::getDeclaration(m_module.get(), llvm::Intrinsic::round, { count->getType() });
                 count = m_builder.CreateCall(roundFunc, { count });
-                count = m_builder.CreateFPToSI(count, m_builder.getInt64Ty()); // cast to signed integer
+                count = m_builder.CreateFPToUI(count, m_builder.getInt64Ty()); // cast to unsigned integer
                 count = m_builder.CreateSelect(isInf, zero, count);
 
                 // Jump to condition branch
@@ -884,7 +884,7 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()
                 if (loop.isRepeatLoop) {
                     // Increment index
                     llvm::Value *currentIndex = m_builder.CreateLoad(m_builder.getInt64Ty(), loop.index);
-                    llvm::Value *incremented = m_builder.CreateAdd(currentIndex, llvm::ConstantInt::get(m_builder.getInt64Ty(), 1, true));
+                    llvm::Value *incremented = m_builder.CreateAdd(currentIndex, llvm::ConstantInt::get(m_builder.getInt64Ty(), 1, false));
                     m_builder.CreateStore(incremented, loop.index);
                 }
 

test/dev/llvm/llvmcodebuilder_test.cpp

@@ -2907,7 +2907,8 @@ TEST_F(LLVMCodeBuilderTest, RepeatLoop)
     v = m_builder->addConstValue(2);
     v = callConstFuncForType(ValueType::Number, v);
     m_builder->beginRepeatLoop(v);
-    m_builder->addTargetFunctionCall("test_function_no_args", Compiler::StaticType::Void, {}, {});
+    CompilerValue *index = m_builder->addLoopIndex();
+    m_builder->addTargetFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { index });
     m_builder->endLoop();
 
     // Nested
@@ -2928,8 +2929,8 @@ TEST_F(LLVMCodeBuilderTest, RepeatLoop)
         v = m_builder->addConstValue(3);
         m_builder->beginRepeatLoop(v);
         {
-            v = m_builder->addConstValue(3);
-            m_builder->addTargetFunctionCall("test_function_1_arg", Compiler::StaticType::Void, { Compiler::StaticType::String }, { v });
+            index = m_builder->addLoopIndex();
+            m_builder->addTargetFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { index });
         }
         m_builder->endLoop();
     }
@@ -2950,20 +2951,20 @@ TEST_F(LLVMCodeBuilderTest, RepeatLoop)
         "1_arg 1\n"
         "1_arg 1\n"
         "1_arg 1\n"
-        "no_args\n"
-        "no_args\n"
+        "0\n"
+        "1\n"
         "1_arg 1\n"
         "1_arg 1\n"
         "1_arg 2\n"
-        "1_arg 3\n"
-        "1_arg 3\n"
-        "1_arg 3\n"
+        "0\n"
+        "1\n"
+        "2\n"
         "1_arg 1\n"
         "1_arg 1\n"
         "1_arg 2\n"
-        "1_arg 3\n"
-        "1_arg 3\n"
-        "1_arg 3\n";
+        "0\n"
+        "1\n"
+        "2\n";
 
     EXPECT_CALL(m_target, isStage).WillRepeatedly(Return(false));
     testing::internal::CaptureStdout();

test/mocks/codebuildermock.h

@@ -13,6 +13,7 @@ class CodeBuilderMock : public ICodeBuilder
         MOCK_METHOD(CompilerValue *, addTargetFunctionCall, (const std::string &, Compiler::StaticType, const Compiler::ArgTypes &, const Compiler::Args &), (override));
         MOCK_METHOD(CompilerValue *, addFunctionCallWithCtx, (const std::string &, Compiler::StaticType, const Compiler::ArgTypes &, const Compiler::Args &), (override));
         MOCK_METHOD(CompilerConstant *, addConstValue, (const Value &), (override));
+        MOCK_METHOD(CompilerValue *, addLoopIndex, (), (override));
         MOCK_METHOD(CompilerValue *, addVariableValue, (Variable *), (override));
         MOCK_METHOD(CompilerValue *, addListContents, (List *), (override));
         MOCK_METHOD(CompilerValue *, addListItem, (List *, CompilerValue *), (override));