Fix conversion of NaN to bool

Author: adazem009

src/scratch/value_functions.cpp

@@ -238,7 +238,7 @@ extern "C"
         if (v->type == ValueType::Bool) {
             return v->boolValue;
         } else if (v->type == ValueType::Number) {
-            return v->numberValue != 0;
+            return v->numberValue != 0 && !std::isnan(v->numberValue);
         } else if (v->type == ValueType::String) {
             return value_stringToBool(v->stringValue);
         } else {

test/scratch_classes/value_test.cpp

@@ -1152,6 +1152,15 @@ TEST(ValueTest, ToBool)
     v = -2.54;
     ASSERT_EQ(v.toBool(), true);
 
+    v = std::numeric_limits<double>::infinity();
+    ASSERT_EQ(v.toBool(), true);
+
+    v = -std::numeric_limits<double>::infinity();
+    ASSERT_EQ(v.toBool(), true);
+
+    v = std::numeric_limits<double>::quiet_NaN();
+    ASSERT_EQ(v.toBool(), false);
+
     v = false;
     ASSERT_EQ(v.toBool(), false);
     v = true;