fix(no-unlocalized-strings): only ignore direct property values in styling constants

- Prevents false negatives for strings inside IIFEs, function calls, nested objects
- Exact path check: Literal → Property → ObjectExpression → VariableDeclarator

Author: swernerx

src/rules/no-unlocalized-strings.test.ts

@@ -127,6 +127,8 @@ ruleTester.run("no-unlocalized-strings", noUnlocalizedStrings, {
     // Singular forms
     { code: 'const DEFAULT_COLOR = { value: "#ff0000" }', filename: "test.tsx" },
     { code: 'const MAIN_CLASS = { container: "mx-auto max-w-7xl" }', filename: "test.tsx" },
+    // Nested objects should NOT be ignored (only direct property values)
+    // These are in the invalid section below
 
     // Technical strings (no spaces, identifiers)
     { code: 'const x = "myIdentifier"', filename: "test.tsx" },
@@ -435,6 +437,24 @@ ruleTester.run("no-unlocalized-strings", noUnlocalizedStrings, {
       code: 'export const testAction = () => { return "Something went wrong!" }',
       filename: "test.tsx",
       errors: [{ messageId: "unlocalizedString" }]
+    },
+
+    // Styling constants: only DIRECT property values are ignored
+    // Functions, IIFEs, nested objects, etc. should still be flagged
+    {
+      code: 'const STATUS_COLORS = { active: (() => "Hello World")() }',
+      filename: "test.tsx",
+      errors: [{ messageId: "unlocalizedString" }]
+    },
+    {
+      code: 'const STATUS_COLORS = { active: fn("Hello World") }',
+      filename: "test.tsx",
+      errors: [{ messageId: "unlocalizedString" }]
+    },
+    {
+      code: 'const STATUS_COLORS = { active: { nested: "Hello World" } }',
+      filename: "test.tsx",
+      errors: [{ messageId: "unlocalizedString" }]
     }
   ]
 })

src/rules/no-unlocalized-strings.ts

@@ -568,28 +568,37 @@ function isIgnoredProperty(node: TSESTree.Node, ignoreProperties: string[]): boo
 }
 
 /**
- * Checks if a string is inside an object assigned to a styling constant.
+ * Checks if a string is a direct property value in an object assigned to a styling constant.
  *
- * Matches patterns like:
+ * Only matches the exact structure:
  *   const STATUS_COLORS = { active: "bg-green-100..." }
- *   const BUTTON_STYLES = { primary: "px-4 py-2..." }
+ *
+ * Does NOT match strings inside functions, IIFEs, or nested structures:
+ *   const STATUS_COLORS = { active: (() => "value")() }  // ❌ not matched
+ *   const STATUS_COLORS = { active: fn("value") }        // ❌ not matched
  */
 function isInsideStylingConstant(node: TSESTree.Node): boolean {
-  let current: TSESTree.Node | undefined = node.parent ?? undefined
+  // Must be: Literal → Property (as value) → ObjectExpression → VariableDeclarator
+  const property = node.parent
+  if (property?.type !== AST_NODE_TYPES.Property || property.value !== node) {
+    return false
+  }
 
-  while (current !== undefined) {
-    // Look for: const NAME = { ... } or let NAME = { ... }
-    if (
-      current.type === AST_NODE_TYPES.VariableDeclarator &&
-      current.id.type === AST_NODE_TYPES.Identifier &&
-      isStylingConstant(current.id.name)
-    ) {
-      return true
-    }
-    current = current.parent ?? undefined
+  const objectExpr = property.parent
+  if (objectExpr.type !== AST_NODE_TYPES.ObjectExpression) {
+    return false
   }
 
-  return false
+  const declarator = objectExpr.parent
+  if (
+    declarator.type !== AST_NODE_TYPES.VariableDeclarator ||
+    declarator.id.type !== AST_NODE_TYPES.Identifier ||
+    declarator.init !== objectExpr
+  ) {
+    return false
+  }
+
+  return isStylingConstant(declarator.id.name)
 }
 
 // ============================================================================