From f4eb1a102a93a3bc1f170b6770b10bff8659c0ee Mon Sep 17 00:00:00 2001 From: Marc Rufer Date: Sun, 7 Dec 2025 23:47:46 +0100 Subject: [PATCH] Fix SonarQube Cloud findings --- .github/workflows/deploy-to-azure.yml | 2 +- .github/workflows/dotnet-and-npm-build.yml | 2 +- server/Cae/CaeClaimsChallengeService.cs | 2 +- server/Program.cs | 9 --------- ui/src/app/secure-api.interceptor.ts | 2 +- 5 files changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/workflows/deploy-to-azure.yml b/.github/workflows/deploy-to-azure.yml index f2ef303..f710593 100644 --- a/.github/workflows/deploy-to-azure.yml +++ b/.github/workflows/deploy-to-azure.yml @@ -45,7 +45,7 @@ jobs: - name: npm setup working-directory: ui - run: npm install --force + run: npm install --force --ignore-scripts - name: ui-angular-cli-build working-directory: ui diff --git a/.github/workflows/dotnet-and-npm-build.yml b/.github/workflows/dotnet-and-npm-build.yml index 5dbe112..6a84585 100644 --- a/.github/workflows/dotnet-and-npm-build.yml +++ b/.github/workflows/dotnet-and-npm-build.yml @@ -23,7 +23,7 @@ jobs: - name: npm setup working-directory: ui - run: npm install --force + run: npm install --force --ignore-scripts - name: ui-angular-cli-build working-directory: ui diff --git a/server/Cae/CaeClaimsChallengeService.cs b/server/Cae/CaeClaimsChallengeService.cs index 1d693e3..70c4520 100644 --- a/server/Cae/CaeClaimsChallengeService.cs +++ b/server/Cae/CaeClaimsChallengeService.cs @@ -10,7 +10,7 @@ /// /// This class is only required if using a standalone AuthContext check /// -public class CaeClaimsChallengeService +public static class CaeClaimsChallengeService { public static string? CheckForRequiredAuthContextIdToken(string authContextId, HttpContext context) { diff --git a/server/Program.cs b/server/Program.cs index 090cc81..cc78dcb 100644 --- a/server/Program.cs +++ b/server/Program.cs @@ -27,7 +27,6 @@ }); services.AddScoped(); -services.AddScoped(); services.AddAntiforgery(options => { @@ -115,11 +114,3 @@ app.MapFallbackToPage("/_Host"); await app.RunAsync(); - -/// -/// Expose implicitly defined Program class to the integration test project -/// See https://learn.microsoft.com/en-us/aspnet/core/test/integration-tests?view=aspnetcore-9.0&pivots=xunit&WT.mc_id=MVP_344197#basic-tests-with-the-default-webapplicationfactory -/// -#pragma warning disable S1118 // Utility classes should not have public constructors -public partial class Program { } -#pragma warning restore S1118 // Utility classes should not have public constructors diff --git a/ui/src/app/secure-api.interceptor.ts b/ui/src/app/secure-api.interceptor.ts index e6bd9c8..c01f492 100644 --- a/ui/src/app/secure-api.interceptor.ts +++ b/ui/src/app/secure-api.interceptor.ts @@ -7,7 +7,7 @@ export function secureApiInterceptor( ) { const secureRoutes = [getApiUrl()]; - if (!secureRoutes.find((x) => request.url.startsWith(x))) { + if (!secureRoutes.some((x) => request.url.startsWith(x))) { return next(request); }