#36 Fix facotry method for service

The method must be static so it is possible to call it like:

```
ImportScanService.createDefault(config);
```

Also removes redundant null check.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanService.java

@@ -9,6 +9,7 @@
 import io.securecodebox.persistence.defectdojo.config.DefectDojoConfig;
 import io.securecodebox.persistence.defectdojo.exceptions.DefectDojoPersistenceException;
 import io.securecodebox.persistence.defectdojo.models.ScanFile;
+import lombok.Getter;
 import lombok.NonNull;
 import org.apache.http.HttpHost;
 import org.apache.http.auth.AuthScope;
@@ -34,9 +35,14 @@
 import java.nio.charset.StandardCharsets;
 import java.util.List;
 
-final class DefaultImportScanService implements ImportScanService {
+/*
+ * https://defectdojo.security.iteratec.dev/api/v2/oa3/swagger-ui/#operations-tag-import-scan
+ */
+class DefaultImportScanService implements ImportScanService {
     private final SystemPropertyFinder properties = new SystemPropertyFinder();
+    @Getter
     private final String defectDojoUrl;
+    @Getter
     private final String defectDojoApiKey;
 
     /**

src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService.java

@@ -11,7 +11,6 @@
 import io.securecodebox.persistence.defectdojo.models.ScanFile;
 import lombok.Data;
 import lombok.Getter;
-import lombok.NonNull;
 import org.springframework.util.LinkedMultiValueMap;
 import org.springframework.util.MultiValueMap;
 
@@ -25,7 +24,7 @@ public interface ImportScanService {
      * @param config must not be {@code null}
      * @return never {@code null}
      */
-    default ImportScanService createDefault(@NonNull DefectDojoConfig config) {
+    static ImportScanService createDefault(final DefectDojoConfig config) {
         return new DefaultImportScanService(config);
     }
 

src/test/java/io/securecodebox/persistence/defectdojo/service/ImportScanServiceTest.java

@@ -0,0 +1,38 @@
+package io.securecodebox.persistence.defectdojo.service;
+
+import io.securecodebox.persistence.defectdojo.config.DefectDojoConfig;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.*;
+
+/**
+ * Tests for {@link ImportScanService}.
+ */
+class ImportScanServiceTest {
+
+    @Test
+    void createDefault_throwsExceptionIfNullPassedIn() {
+        assertThrows(NullPointerException.class, () -> {
+            ImportScanService.createDefault(null);
+        });
+    }
+    
+    @Test
+    void createDefault_passesConfig() {
+        final var config = new DefectDojoConfig(
+            "url",
+            "apiKey",
+            "username",
+            23,
+            42L
+        );
+
+        final var sut = (DefaultImportScanService) ImportScanService.createDefault(config);
+
+        assertAll(
+            () -> assertThat(sut.getDefectDojoUrl(), is(config.getUrl())),
+            () -> assertThat(sut.getDefectDojoApiKey(), is(config.getApiKey())));
+    }
+}