Clean up streaming code

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/service/FindingService.java

@@ -37,14 +37,24 @@ protected Response<Finding> deserializeList(String response) throws JsonProcessi
   }
 
   public List<Finding> getUnhandledFindingsForProduct(long productId, Finding.Severity minimumSeverity) throws URISyntaxException, JsonProcessingException {
-    return this.search(Map.of("test__engagement__product", Long.toString(productId), "active", Boolean.toString(true))).stream().filter((finding -> {
-      return finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation();
-    })).collect(Collectors.toList());
+    final Map<String, Object> queryParams = Map.of(
+      "test__engagement__product", Long.toString(productId),
+      "active", Boolean.toString(true));
+
+    return this.search(queryParams)
+      .stream()
+      .filter((finding -> finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation()))
+      .toList();
   }
 
   public List<Finding> getUnhandledFindingsForEngagement(long engagementId, Finding.Severity minimumSeverity) throws URISyntaxException, JsonProcessingException {
-    return this.search(Map.of("test__engagement", Long.toString(engagementId), "active", Boolean.toString(true))).stream().filter((finding -> {
-      return finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation();
-    })).collect(Collectors.toList());
+    final Map<String, Object> queryParams = Map.of(
+      "test__engagement", Long.toString(engagementId),
+      "active", Boolean.toString(true));
+
+    return this.search(queryParams)
+      .stream()
+      .filter((finding -> finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation()))
+      .toList();
   }
 }