Fix error in search codes if pagination is triggered

Author: J12934

src/main/java/io/securecodebox/persistence/defectdojo/service/FindingService.java

@@ -33,12 +33,13 @@ protected DefectDojoResponse<Finding> deserializeList(String response) throws Js
   }
 
   public List<Finding> getUnhandledFindingsForProduct(long productId, Finding.Severity minimumSeverity) throws URISyntaxException, JsonProcessingException {
-    return this.search(Map.of("test__engagement__product", productId, "active", true)).stream().filter((finding -> {
+    return this.search(Map.of("test__engagement__product", Long.toString(productId), "active", Boolean.toString(true))).stream().filter((finding -> {
       return finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation();
     })).collect(Collectors.toList());
   }
+
   public List<Finding> getUnhandledFindingsForEngagement(long engagementId, Finding.Severity minimumSeverity) throws URISyntaxException, JsonProcessingException {
-    return this.search(Map.of("test__engagement", engagementId, "active", true)).stream().filter((finding -> {
+    return this.search(Map.of("test__engagement", Long.toString(engagementId), "active", Boolean.toString(true))).stream().filter((finding -> {
       return finding.getSeverity().getNumericRepresentation() >= minimumSeverity.getNumericRepresentation();
     })).collect(Collectors.toList());
   }

src/main/java/io/securecodebox/persistence/defectdojo/service/GenericDefectDojoService.java

@@ -107,11 +107,10 @@ public List<T> search(Map<String, Object> queryParams) throws URISyntaxException
     do {
       var response = internalSearch(queryParams, DEFECT_DOJO_OBJET_LIMIT, DEFECT_DOJO_OBJET_LIMIT * page++);
       objects.addAll(response.getResults());
-      if (response.getNext() != null) {
-        hasNext = true;
-      }
+
+      hasNext = response.getNext() != null;
       if (page > 100) {
-        throw new DefectDojoLoopException("Looked for DefectDojo Object but could not find it after " + page + " paginated API pages of " + DEFECT_DOJO_OBJET_LIMIT + " each.");
+        throw new DefectDojoLoopException("Found too many response object. Quitting after " + page + " paginated API pages of " + DEFECT_DOJO_OBJET_LIMIT + " each.");
       }
     } while (hasNext);