#23 Add Identical Behaviour Likethe Others Implementations Have

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/model/UserProfile.java

@@ -23,10 +23,12 @@ public final class UserProfile implements Model {
 
   @Override
   public boolean equalsQueryString(Map<String, Object> queryParams) {
+    if (QueryParamsComparator.isNull(queryParams)) {
+      return false;
+    }
+
     // The user_profile endpoint does not have query parameters that's
     // why this function will just return true.
-    // TODO: All other implementations return false if null is given for queryParams.
-    //       We should consider to change this API according to that.
     return true;
   }
 

src/test/java/io/securecodebox/persistence/defectdojo/model/UserProfileTest.java

@@ -22,11 +22,18 @@ void equalsAndHashCode() {
   }
 
   @Test
-  void equalsQueryString_alwaysTrue() {
+  void equalsQueryString_alwaysTrueIfNotNullGiven() {
     final var sut = UserProfile.builder()
       .build();
 
-    assertThat(sut.equalsQueryString(null), is(true));
     assertThat(sut.equalsQueryString(Collections.emptyMap()), is(true));
   }
+
+  @Test
+  void equalsQueryString_alwaysFalseIfNull() {
+    final var sut = UserProfile.builder()
+      .build();
+
+    assertThat(sut.equalsQueryString(null), is(false));
+  }
 }