Skip to content

Commit c28114f

Browse files
committed
#36 Move overloaded method beneath the origin method
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 37948cc commit c28114f

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/service/ImportScanService.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -127,25 +127,24 @@ public String getFilename() {
127127

128128
public ImportScanResponse importScan(ScanFile scanFile, long engagementId, long lead, String currentDate, ScanType scanType, long testType) {
129129
var additionalValues = new LinkedMultiValueMap<String, Object>();
130-
additionalValues.add("engagement", Long.toString(engagementId));
130+
additionalValues.add("engagement", Long.toString(engagementId)); // FIXME Seems to be duplicated.
131131

132132
return this.importScan(scanFile, engagementId, lead, currentDate, scanType, testType, additionalValues);
133133
}
134134

135-
public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead, String currentDate, ScanType scanType, long testType) {
136-
var additionalValues = new LinkedMultiValueMap<String, Object>();
137-
additionalValues.add("test", Long.toString(testId));
138-
139-
return this.reimportScan(scanFile, testId, lead, currentDate, scanType, testType, additionalValues);
140-
}
141-
142-
//overloading with optional parameter
143135
public ImportScanResponse importScan(ScanFile scanFile, long engagementId, long lead, String currentDate, ScanType scanType, long testType, LinkedMultiValueMap<String, Object> additionalValues) {
144136
additionalValues.add("engagement", Long.toString(engagementId));
145137

146138
return this.createFindings(scanFile, "import-scan", lead, currentDate, scanType, testType, additionalValues);
147139
}
148140

141+
public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead, String currentDate, ScanType scanType, long testType) {
142+
var additionalValues = new LinkedMultiValueMap<String, Object>();
143+
additionalValues.add("test", Long.toString(testId)); // FIXME Seems to be duplicated.
144+
145+
return this.reimportScan(scanFile, testId, lead, currentDate, scanType, testType, additionalValues);
146+
}
147+
149148
public ImportScanResponse reimportScan(ScanFile scanFile, long testId, long lead, String currentDate, ScanType scanType, long testType, LinkedMultiValueMap<String, Object> additionalValues) {
150149
additionalValues.add("test", Long.toString(testId));
151150

0 commit comments

Comments
 (0)