#36 Factor out method to generate API URL

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanService.java

@@ -122,12 +122,16 @@ public String getFilename() {
             // FIXME: We do not define the the type T of the body here!
             final var payload = new HttpEntity<MultiValueMap<String, Object>>(body, headers);
 
-            return restTemplate.exchange(defectDojoUrl + "/api/v2/" + endpoint + "/", HttpMethod.POST, payload, ImportScanResponse.class).getBody();
+            return restTemplate.exchange(generateApiUrl(endpoint), HttpMethod.POST, payload, ImportScanResponse.class).getBody();
         } catch (HttpClientErrorException e) {
             throw new DefectDojoPersistenceException("Failed to attach findings to engagement.");
         }
     }
 
+    String generateApiUrl(final String endpoint) {
+        return String.format("%s/api/v2/%s/", getDefectDojoUrl(), endpoint);
+    }
+
     /**
      * The DefectDojo Authentication Header
      *

src/test/java/io/securecodebox/persistence/defectdojo/service/DefaultImportScanServiceTest.java

@@ -20,7 +20,7 @@
  */
 class DefaultImportScanServiceTest {
     private final DefectDojoConfig config = new DefectDojoConfig(
-        "url",
+        "http://localhost",
         "apiKey",
         "username",
         23,
@@ -169,8 +169,13 @@ void createRequestFactoryWithProxyAuthConfig_throesExceptionIfPortIsNotInteger()
             IllegalArgumentException.class,
             sut::createRequestFactoryWithProxyAuthConfig);
 
-        assertEquals(
-            "Given port for proxy authentication configuration (property 'http.proxyPort') is not a valid number! Given value wa 'FUBAR'.",
-            thrown.getMessage());
+        assertThat(
+            thrown.getMessage(),
+            is("Given port for proxy authentication configuration (property 'http.proxyPort') is not a valid number! Given value wa 'FUBAR'."));
+    }
+
+    @Test
+    void generateApiUrl() {
+        assertThat(sut.generateApiUrl("foo"), is("http://localhost/api/v2/foo/"));
     }
 }