Fix ordering issues in ScheduledScans

Timestamp wasn't properly set.
Reverting to just using native kubernetes creation timestamp
as the are more reliable.

Author: J12934

operator/apis/execution/v1/scan_types.go

@@ -44,8 +44,6 @@ type ScanStatus struct {
 	// RawResultFile Filename of the result file of the scanner. e.g. `nmap-result.xml`
 	RawResultFile string `json:"rawResultFile,omitempty"`
 
-	StartTime *metav1.Time `json:"startTime,omitempty"`
-
 	Findings FindingStats `json:"findings,omitempty"`
 }
 

operator/apis/execution/v1/zz_generated.deepcopy.go

@@ -113,9 +113,6 @@ spec:
               description: RawResultType determines which kind of ParseDefinition
                 will be used to turn the raw results of the scanner into findings
               type: string
-            startTime:
-              format: date-time
-              type: string
             state:
               type: string
           type: object

operator/config/crd/bases/execution.experimental.securecodebox.io_scans.yaml

@@ -75,10 +75,7 @@ func (r *ScheduledScanReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
 	}
 
 	sort.Slice(completedScans, func(i, j int) bool {
-		if completedScans[i].Status.StartTime == nil {
-			return completedScans[j].Status.StartTime != nil
-		}
-		return completedScans[i].Status.StartTime.Before(completedScans[j].Status.StartTime)
+		return completedScans[i].ObjectMeta.CreationTimestamp.Before(&completedScans[j].ObjectMeta.CreationTimestamp)
 	})
 
 	if len(completedScans) >= 1 {
@@ -126,8 +123,6 @@ func (r *ScheduledScanReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
 			Spec: *scheduledScan.Spec.ScanSpec.DeepCopy(),
 		}
 		scan.Name = fmt.Sprintf("%s-%d", scheduledScan.Name, nextSchedule.Unix())
-		metaNow := metav1.Now()
-		scan.Status.StartTime = &metaNow
 		if err := ctrl.SetControllerReference(&scheduledScan, scan, r.Scheme); err != nil {
 			log.Error(err, "unable to set owner reference on scan")
 			return ctrl.Result{}, err