You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Copy file name to clipboardExpand all lines: docs/adr/adr_0001.adoc
+12-11Lines changed: 12 additions & 11 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -64,9 +64,9 @@ The are two variants:
64
64
65
65
We could do a similar thing and introduce CRD which allows to execute "custom code" (generally speaking, depends on the second question) after a scan has completed (meaning both scan and parser phases are done). Some name ideas:
66
66
67
-
- `ScanHooks`
68
-
- `ScanCompletionHooks`
69
-
- `FindingProcessors`
67
+
* `ScanHooks`
68
+
* `ScanCompletionHooks`
69
+
* `FindingProcessors`
70
70
71
71
These could be implemented with a `type` attribute, which declares if they are `ReadOnly` or `ReadAndWrite`.
72
72
@@ -99,14 +99,14 @@ The Execution Flow would then look something like this:
99
99
100
100
**Pros:**
101
101
102
-
- Only one Implementation
103
-
- Pretty Generic to expand and test out new ideas without having to modify the secureCodeBox Operator
102
+
* Only one Implementation
103
+
* Pretty Generic to expand and test out new ideas without having to modify the secureCodeBox Operator
104
104
105
105
**Cons:**
106
106
107
-
- Possible "over-abstraction"?
108
-
- Need to refactor the ElasticSearch PersistenceProvider
109
-
- The "General Implementation" will be harder than the individual ones
107
+
* Possible "over-abstraction"?
108
+
* Need to refactor the ElasticSearch PersistenceProvider
109
+
* The "General Implementation" will be harder than the individual ones
110
110
111
111
==== Solution approach 1: Keep Split between Persistence Provider and MetaData Provider
112
112
@@ -125,12 +125,12 @@ Keep PersistenceProvider as they are and introduce new "MetaDataProvider" CRD wh
125
125
126
126
**Pros:**
127
127
128
-
- Quicker to implement
129
-
- Might be worth it to have a seperate concept for it
128
+
* Quicker to implement
129
+
* Might be worth it to have a seperate concept for it
130
130
131
131
**Cons:**
132
132
133
-
- Really worth introducing a new CRD for everything, especially when the are conceptually pretty close?
133
+
* Really worth introducing a new CRD for everything, especially when the are conceptually pretty close?
134
134
135
135
=== Question 2: How should the execution model look like for each?
136
136
@@ -211,6 +211,7 @@ The Phase 3 `DataProcessing` will be therefore splitt into to seperate phases na
211
211
With the new `Hook Concept` we open the `DataProcessing` Phase 3 to a more intuitive and flexible architecture. It is easier to understand because _WebHooks_ are already a well known concept. It is possible to keep the existing implementation of the `persistenceProviders` and to integrate them with a lot of other possible data processing components in a more general fashion. In the end, this step will result in a lot of additional feature possibilities, which go fare beyond the existing ones. Therefore we only need to implement this concept once in the secureCodeBox Operator and new ideas for extending the DataProcessing will not enforce conceptual or architectural changes.
212
212
213
213
Ideas for additional data processing hooks:
214
+
214
215
* Notifier-Hooks (ReadOnlyHook) e.g. for chat systems (slack, teams...) or metric / alerting systems
0 commit comments