#33 #21 Truncate ending dots

This would otherwise lead to invalid names for k8s objects

Author: J12934

operator/utils/truncatedname.go

@@ -1,11 +1,21 @@
 package utils
 
-import "fmt"
+import (
+	"fmt"
+	"strings"
+)
 
 // TruncateName Ensures that the name used for a kubernetes object doesn't exceed the 63 char length limit. This actually cuts of anything after char 57, so that we can use the randomly generated suffix from k8s `generateName`.
 func TruncateName(name string) string {
 	if len(name) >= 57 {
-		return fmt.Sprintf("%s-", name[0:57])
+		name = name[0:57]
 	}
+
+	// Ensure that the string does not end in a dot.
+	// This would not be a valid domain name thous rejected by kubernetes
+	if strings.HasSuffix(name, ".") {
+		name = name[0:(len(name) - 1)]
+	}
+
 	return fmt.Sprintf("%s-", name)
 }

operator/utils/truncatedname_test.go

@@ -24,6 +24,16 @@ func TestAbc(t *testing.T) {
 			in:  "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
 			out: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-",
 		},
+		// Truncates strings ending in dots
+		{
+			in:  "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.",
+			out: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-",
+		},
+		// Also removes dots even when they are not the last char
+		{
+			in:  "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.a",
+			out: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-",
+		},
 	}
 
 	for _, test := range tests {