From 6edd5695cb451e89076fd8d13d33abf6d2ba0683 Mon Sep 17 00:00:00 2001
From: Sylvain <1552102+sgaunet@users.noreply.github.com>
Date: Sun, 7 Dec 2025 20:29:04 +0100
Subject: [PATCH] fix(client): eliminate unreachable code in Close method

Refactor Close() to use early return pattern, removing unreachable
return statement that occurred when c.db was nil. The new implementation
checks for nil database first, making the control flow clearer and
eliminating the code path that could never be executed.
---
 internal/app/client.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/internal/app/client.go b/internal/app/client.go
index 85b858c..ffa4467 100644
--- a/internal/app/client.go
+++ b/internal/app/client.go
@@ -40,12 +40,12 @@ func (c *PostgreSQLClientImpl) Connect(connectionString string) error {
 
 // Close closes the database connection.
 func (c *PostgreSQLClientImpl) Close() error {
-	if c.db != nil {
-		if err := c.db.Close(); err != nil {
-			return fmt.Errorf("failed to close database: %w", err)
-		}
+	if c.db == nil {
 		return nil
 	}
+	if err := c.db.Close(); err != nil {
+		return fmt.Errorf("failed to close database: %w", err)
+	}
 	return nil
 }