Skip to content

Commit 8b69a5a

Browse files
Remove redundant RuboCop disable directives for Metrics/CyclomaticComplexity
The root config increased the cyclomatic complexity threshold from 7 to 8, making these disable comments unnecessary. All 12 methods now comply with the new threshold naturally. Co-authored-by: Ihab Adham <ihabadham@users.noreply.github.com>
1 parent d92a090 commit 8b69a5a

File tree

6 files changed

+1
-12
lines changed

6 files changed

+1
-12
lines changed

react_on_rails/lib/generators/react_on_rails/templates/base/base/bin/switch-bundler

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ class BundlerSwitcher
6161
puts "✅ Updated assets_bundler to '#{@target_bundler}'"
6262
end
6363

64-
# rubocop:disable Metrics/CyclomaticComplexity
6564
def update_dependencies
6665
puts "📦 Updating package.json dependencies..."
6766

@@ -88,7 +87,6 @@ class BundlerSwitcher
8887
end
8988
# rubocop:enable Metrics/CyclomaticComplexity
9089

91-
# rubocop:disable Metrics/CyclomaticComplexity
9290
def install_dependencies
9391
puts "📥 Installing #{@target_bundler} dependencies..."
9492

react_on_rails/lib/react_on_rails/doctor.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,6 @@ def check_version_wildcards
468468
check_npm_wildcards
469469
end
470470

471-
# rubocop:disable Metrics/CyclomaticComplexity
472471
def check_gem_wildcards
473472
gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
474473
return unless File.exist?(gemfile_path)
@@ -492,7 +491,6 @@ def check_gem_wildcards
492491
end
493492
# rubocop:enable Metrics/CyclomaticComplexity
494493

495-
# rubocop:disable Metrics/CyclomaticComplexity
496494
def check_npm_wildcards
497495
return unless File.exist?("package.json")
498496

@@ -538,7 +536,6 @@ def check_key_configuration_files
538536
check_server_rendering_engine
539537
end
540538

541-
# rubocop:disable Metrics/CyclomaticComplexity
542539
def check_layout_files
543540
layout_files = Dir.glob("app/views/layouts/**/*.erb")
544541
return if layout_files.empty?
@@ -603,7 +600,6 @@ def check_server_rendering_engine
603600
end
604601
# rubocop:enable Metrics/CyclomaticComplexity
605602

606-
# rubocop:disable Metrics/CyclomaticComplexity
607603
def check_shakapacker_configuration_details
608604
return unless File.exist?("config/shakapacker.yml")
609605

react_on_rails/lib/react_on_rails/server_rendering_pool/ruby_embedded_java_script.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def reset_pool_if_server_bundle_was_modified
5050
# Note, js_code does not have to be based on React.
5151
# js_code MUST RETURN json stringify Object
5252
# Calling code will probably call 'html_safe' on return value before rendering to the view.
53-
# rubocop:disable Metrics/CyclomaticComplexity
5453
def exec_server_render_js(js_code, render_options, js_evaluator = nil)
5554
js_evaluator ||= self
5655
if render_options.trace

react_on_rails/lib/react_on_rails/system_checker.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ def check_react_on_rails_npm_package
203203
add_warning("⚠️ Could not parse package.json")
204204
end
205205

206-
def check_package_version_sync # rubocop:disable Metrics/CyclomaticComplexity
206+
def check_package_version_sync
207207
return unless File.exist?("package.json")
208208

209209
begin
@@ -540,7 +540,6 @@ def check_version_patterns(npm_version, gem_version)
540540
MSG
541541
end
542542

543-
# rubocop:disable Metrics/CyclomaticComplexity
544543
def check_gemfile_version_patterns
545544
gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
546545
return unless File.exist?(gemfile_path)
@@ -573,7 +572,6 @@ def check_gemfile_version_patterns
573572
end
574573
# rubocop:enable Metrics/CyclomaticComplexity
575574

576-
# rubocop:disable Metrics/CyclomaticComplexity
577575
def report_dependency_versions(package_json)
578576
all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
579577

react_on_rails/lib/react_on_rails/utils.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,6 @@ def self.package_manager_remove_command(package_name)
467467
#
468468
# @example Absolute paths outside Rails.root (edge case)
469469
# normalize_to_relative_path("/other/path/bundles") # => "/other/path/bundles"
470-
# rubocop:disable Metrics/CyclomaticComplexity
471470
def self.normalize_to_relative_path(path)
472471
return nil if path.nil?
473472

react_on_rails/lib/react_on_rails/version_checker.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,6 @@ def parts
338338
private
339339

340340
# Resolve version from lockfiles if available, otherwise use package.json version
341-
# rubocop:disable Metrics/CyclomaticComplexity
342341
def resolve_version(package_json_version, package_name)
343342
# If package.json specifies a local path or URL, don't try to resolve from lockfiles
344343
# Lockfiles may contain placeholder versions like "0.0.0" for local links

0 commit comments

Comments
 (0)