Skip to content

Commit ad334ea

Browse files
justin808claude
andcommitted
Fix yalc add to use --link flag for pnpm lockfile compatibility
The pnpm-lock.yaml in spec/dummy uses link: protocol for the react-on-rails dependency, but yalc add (without --link) changes package.json to use file: protocol, causing ERR_PNPM_OUTDATED_LOCKFILE errors in CI. Adding --link flag ensures yalc maintains the link: protocol that matches the lockfile, fixing all CI workflow failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 110dcae commit ad334ea

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.github/workflows/integration-tests.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ jobs:
150150
- name: yalc publish for react-on-rails
151151
run: cd packages/react-on-rails && yalc publish
152152
- name: yalc add react-on-rails
153-
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
153+
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
154+
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
154155
- name: Install Node modules with pnpm for dummy app
155156
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
156157
# The dummy app doesn't have a pnpm-lock.yaml and shouldn't use frozen lockfile
@@ -256,7 +257,8 @@ jobs:
256257
- name: yalc publish for react-on-rails
257258
run: cd packages/react-on-rails && yalc publish
258259
- name: yalc add react-on-rails
259-
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
260+
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
261+
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
260262
- name: Install Node modules with pnpm for dummy app
261263
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
262264
# The dummy app doesn't have a pnpm-lock.yaml and shouldn't use frozen lockfile

.github/workflows/lint-js-and-ruby.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ jobs:
132132
- name: yalc publish for react-on-rails
133133
run: cd packages/react-on-rails && yalc publish
134134
- name: yalc add react-on-rails
135-
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
135+
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
136+
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
136137
- name: Install Node modules with pnpm for dummy app
137138
# --ignore-workspace prevents pnpm from treating this as part of the parent workspace
138139
# The dummy app has its own dependencies and uses yalc links

.github/workflows/precompile-check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ jobs:
113113
- name: yalc publish for react-on-rails
114114
run: cd packages/react-on-rails && yalc publish
115115
- name: yalc add react-on-rails
116-
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
116+
# Use --link to maintain the link: protocol that matches pnpm-lock.yaml
117+
run: cd react_on_rails/spec/dummy && yalc add --link react-on-rails
117118
- name: Install Node modules with pnpm for dummy app
118119
run: cd react_on_rails/spec/dummy && pnpm install --ignore-workspace
119120
- name: Save dummy app ruby gems to cache

0 commit comments

Comments
 (0)