Use shipmonk/coding-standard (#41)

Author: JanTvrdik

composer.json

@@ -23,11 +23,11 @@
         "phpstan/phpstan-phpunit": "2.0.6",
         "phpstan/phpstan-strict-rules": "2.0.4",
         "phpunit/phpunit": "9.6.23",
+        "shipmonk/coding-standard": "^0.1.3",
         "shipmonk/composer-dependency-analyser": "1.8.3",
         "shipmonk/dead-code-detector": "^0.11.0",
         "shipmonk/name-collision-detector": "2.1.1",
-        "shipmonk/phpstan-rules": "4.1.2",
-        "slevomat/coding-standard": "8.18.0"
+        "shipmonk/phpstan-rules": "4.1.2"
     },
     "autoload": {
         "psr-4": {

phpcs.xml.dist

@@ -29,7 +29,10 @@ class BaselinePerIdentifierFormatter implements ErrorFormatter
 
     private string $indent;
 
-    public function __construct(?string $baselinesDir, string $indent)
+    public function __construct(
+        ?string $baselinesDir,
+        string $indent
+    )
     {
         if ($baselinesDir === null) {
             throw new LogicException('Baselines directory must be set, please set up \'parameters.shipmonkBaselinePerIdentifier.directory\' in your phpstan configuration file');
@@ -133,7 +136,10 @@ public function formatErrors(
         return 0;
     }
 
-    private function getPathDifference(string $from, string $to): string
+    private function getPathDifference(
+        string $from,
+        string $to
+    ): string
     {
         $fromParts = explode(DIRECTORY_SEPARATOR, $from);
         $toParts = explode(DIRECTORY_SEPARATOR, $to);

src/BaselinePerIdentifierFormatter.php

@@ -22,14 +22,18 @@ class BaselineSplitter
 
     private bool $includeCount;
 
-    public function __construct(string $indent, bool $includeCount)
+    public function __construct(
+        string $indent,
+        bool $includeCount
+    )
     {
         $this->indent = $indent;
         $this->includeCount = $includeCount;
     }
 
     /**
      * @return array<string, int|null>
+     *
      * @throws ErrorException
      */
     public function split(string $loaderFilePath): array
@@ -66,7 +70,7 @@ public function split(string $loaderFilePath): array
         foreach ($groupedErrors as $identifier => $errors) {
             $fileName = $identifier . '.' . $extension;
             $filePath = $folder . '/' . $fileName;
-            $errorsCount = array_reduce($errors, static fn(int $carry, array $item): int => $carry + $item['count'], 0);
+            $errorsCount = array_reduce($errors, static fn (int $carry, array $item): int => $carry + $item['count'], 0);
             $totalErrorCount += $errorsCount;
 
             $outputInfo[$filePath] = $errorsCount;
@@ -92,9 +96,13 @@ public function split(string $loaderFilePath): array
     /**
      * @param array<mixed> $errors
      * @return array<string, list<array{message: string, count: int, path: string}>>
+     *
      * @throws ErrorException
      */
-    private function groupErrorsByIdentifier(array $errors, string $folder): array
+    private function groupErrorsByIdentifier(
+        array $errors,
+        string $folder
+    ): array
     {
         $groupedErrors = [];
 
@@ -147,7 +155,10 @@ private function groupErrorsByIdentifier(array $errors, string $folder): array
     /**
      * @throws ErrorException
      */
-    private function writeFile(string $filePath, string $contents): void
+    private function writeFile(
+        string $filePath,
+        string $contents
+    ): void
     {
         $written = file_put_contents($filePath, $contents);
 

src/BaselineSplitter.php

@@ -8,7 +8,10 @@
 class ErrorException extends RuntimeException
 {
 
-    public function __construct(string $message, ?Throwable $previous = null)
+    public function __construct(
+        string $message,
+        ?Throwable $previous = null
+    )
     {
         parent::__construct($message, 0, $previous);
     }

src/Exception/ErrorException.php

@@ -9,18 +9,27 @@ interface BaselineHandler
 
     /**
      * @return array<mixed>
+     *
      * @throws ErrorException
      */
     public function decodeBaseline(string $filepath): array;
 
     /**
      * @param list<array{message: string, count: int, path: string}> $errors
      */
-    public function encodeBaseline(?string $comment, array $errors, string $indent): string;
+    public function encodeBaseline(
+        ?string $comment,
+        array $errors,
+        string $indent
+    ): string;
 
     /**
      * @param list<string> $filePaths
      */
-    public function encodeBaselineLoader(?string $comment, array $filePaths, string $indent): string;
+    public function encodeBaselineLoader(
+        ?string $comment,
+        array $filePaths,
+        string $indent
+    ): string;
 
 }

src/Handler/BaselineHandler.php

@@ -29,13 +29,21 @@ public function decodeBaseline(string $filepath): array
         }
     }
 
-    public function encodeBaseline(?string $comment, array $errors, string $indent): string
+    public function encodeBaseline(
+        ?string $comment,
+        array $errors,
+        string $indent
+    ): string
     {
         $prefix = $comment !== null ? "# $comment\n\n" : '';
         return $prefix . NeonHelper::encode(['parameters' => ['ignoreErrors' => $errors]], $indent);
     }
 
-    public function encodeBaselineLoader(?string $comment, array $filePaths, string $indent): string
+    public function encodeBaselineLoader(
+        ?string $comment,
+        array $filePaths,
+        string $indent
+    ): string
     {
         $prefix = $comment !== null ? "# $comment\n" : '';
         return $prefix . NeonHelper::encode(['includes' => $filePaths], $indent);

src/Handler/NeonBaselineHandler.php

@@ -15,7 +15,7 @@ class PhpBaselineHandler implements BaselineHandler
     public function decodeBaseline(string $filepath): array
     {
         try {
-            $decoded = (static fn() => require $filepath)();
+            $decoded = (static fn () => require $filepath)();
 
             if (!is_array($decoded)) {
                 throw new ErrorException("File '$filepath' must return array, " . gettype($decoded) . ' given');
@@ -28,7 +28,11 @@ public function decodeBaseline(string $filepath): array
         }
     }
 
-    public function encodeBaseline(?string $comment, array $errors, string $indent): string
+    public function encodeBaseline(
+        ?string $comment,
+        array $errors,
+        string $indent
+    ): string
     {
         $php = '<?php declare(strict_types = 1);';
 
@@ -56,7 +60,11 @@ public function encodeBaseline(?string $comment, array $errors, string $indent):
         return $php;
     }
 
-    public function encodeBaselineLoader(?string $comment, array $filePaths, string $indent): string
+    public function encodeBaselineLoader(
+        ?string $comment,
+        array $filePaths,
+        string $indent
+    ): string
     {
         $php = "<?php declare(strict_types = 1);\n\n";
 

src/Handler/PhpBaselineHandler.php

@@ -13,7 +13,10 @@ class NeonHelper
     /**
      * @param mixed $data
      */
-    public static function encode($data, string $indent): string
+    public static function encode(
+        $data,
+        string $indent
+    ): string
     {
         return trim(Neon::encode($data, true, $indent)) . "\n";
     }