minor fixes

Author: ioigoume

src/Controller/Cas20Controller.php

@@ -112,17 +112,19 @@ public function serviceValidate(
      * acquired proxy-granting tickets and will be proxying authentication to back-end services.
      *
      * @param   Request      $request
-     * @param   string|null  $targetService [REQUIRED] - the service identifier of the back-end service.
-     * @param   string|null  $pgt  [REQUIRED] - the proxy-granting ticket acquired by the service
-     *                             during service ticket or proxy ticket validation.
+     * @param   string|null  $targetService  [REQUIRED] - the service identifier of the back-end service.
+     * @param   string|null  $pgt            [REQUIRED] - the proxy-granting ticket acquired by the service
+     *                                       during service ticket or proxy ticket validation.
      *
      * @return XmlResponse
+     * @throws \ErrorException
      */
     public function proxy(
         Request $request,
         #[MapQueryParameter] ?string $targetService = null,
         #[MapQueryParameter] ?string $pgt = null,
     ): XmlResponse {
+        // NOTE: Here we do not override the configuration
         $legal_target_service_urls = $this->casConfig->getOptionalValue('legal_target_service_urls', []);
         // Fail if
         $message = match (true) {

src/Controller/Traits/TicketValidatorTrait.php

@@ -49,7 +49,7 @@ public function validate(
 
         try {
             // Get the service ticket
-            // `getTicket` uses the unserializable method and Objects may throw Throwables in their
+            // `getTicket` uses the unserializable method and Objects may throw "Throwables" in their
             // un-serialization handlers.
             $serviceTicket = $this->ticketStore->getTicket($ticket);
         } catch (\Exception $e) {
@@ -58,7 +58,7 @@ public function validate(
                 $messagePostfix = ': ' . var_export($e->getMessage(), true);
             }
             $message = 'casserver:serviceValidate: internal server error' . $messagePostfix;
-            Logger::error($message);
+            Logger::error(__METHOD__ . '::' . $message);
 
             return new XmlResponse(
                 (string)$this->cas20Protocol->getValidateFailureResponse(C::ERR_INTERNAL_ERROR, $message),
@@ -86,7 +86,7 @@ public function validate(
 
         if ($failed) {
             $finalMessage = 'casserver:validate: ' . $message;
-            Logger::error($finalMessage);
+            Logger::error(__METHOD__ . '::' . $finalMessage);
 
             return new XmlResponse(
                 (string)$this->cas20Protocol->getValidateFailureResponse(C::ERR_INVALID_SERVICE, $message),
@@ -119,7 +119,7 @@ public function validate(
 
         if ($failed) {
             $finalMessage = 'casserver:validate: ' . $message;
-            Logger::error($finalMessage);
+            Logger::error(__METHOD__ . '::' . $finalMessage);
 
             return new XmlResponse(
                 (string)$this->cas20Protocol->getValidateFailureResponse(C::ERR_INVALID_SERVICE, $message),

src/Controller/Traits/UrlTrait.php

@@ -12,11 +12,12 @@
 trait UrlTrait
 {
     /**
-     * @deprecated
-     * @see ServiceValidator
-     * @param string $service
-     * @param array $legal_service_urls
+     * @param   string  $service
+     * @param   array   $legal_service_urls
+     *
      * @return bool
+     * @throws \ErrorException
+     * @see ServiceValidator
      */
     public function checkServiceURL(string $service, array $legal_service_urls): bool
     {