Skip to content

Commit 38944ce

Browse files
committed
ack comments
1 parent 58b2c98 commit 38944ce

File tree

2 files changed

+22
-4
lines changed
  • apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components

2 files changed

+22
-4
lines changed

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/combobox/combobox.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,21 @@ export function ComboBox({
267267
!isPreview &&
268268
!disabled &&
269269
fetchedOptions.length === 0 &&
270-
!isLoadingOptions
270+
!isLoadingOptions &&
271+
!fetchError
271272
) {
272273
fetchOptionsIfNeeded()
273274
}
274275
// eslint-disable-next-line react-hooks/exhaustive-deps -- fetchOptionsIfNeeded deps already covered above
275-
}, [fetchOptions, isPreview, disabled, fetchedOptions.length, isLoadingOptions, dependencyValues])
276+
}, [
277+
fetchOptions,
278+
isPreview,
279+
disabled,
280+
fetchedOptions.length,
281+
isLoadingOptions,
282+
fetchError,
283+
dependencyValues,
284+
])
276285

277286
// Hydrate the stored value's label by fetching it individually
278287
useEffect(() => {

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,12 +359,21 @@ export function Dropdown({
359359
!isPreview &&
360360
!disabled &&
361361
fetchedOptions.length === 0 &&
362-
!isLoadingOptions
362+
!isLoadingOptions &&
363+
!fetchError
363364
) {
364365
fetchOptionsIfNeeded()
365366
}
366367
// eslint-disable-next-line react-hooks/exhaustive-deps -- fetchOptionsIfNeeded deps already covered above
367-
}, [fetchOptions, isPreview, disabled, fetchedOptions.length, isLoadingOptions, dependencyValues])
368+
}, [
369+
fetchOptions,
370+
isPreview,
371+
disabled,
372+
fetchedOptions.length,
373+
isLoadingOptions,
374+
fetchError,
375+
dependencyValues,
376+
])
368377

369378
/**
370379
* Effect to hydrate the stored value's label by fetching it individually

0 commit comments

Comments
 (0)