improvement(avatar): use selection-update as the source of truth for presence, ignore other socket ops (#2866)

* improvement(avatar): use selection-update as the source of truth for presence, ignore other socket ops

* added logs

Author: waleedlatif1

apps/sim/app/workspace/providers/socket-provider.tsx

@@ -406,43 +406,29 @@ export function SocketProvider({ children, user }: SocketProviderProps) {
         socketInstance.on('cursor-update', (data) => {
           setPresenceUsers((prev) => {
             const existingIndex = prev.findIndex((user) => user.socketId === data.socketId)
-            if (existingIndex !== -1) {
-              return prev.map((user) =>
-                user.socketId === data.socketId ? { ...user, cursor: data.cursor } : user
-              )
+            if (existingIndex === -1) {
+              logger.debug('Received cursor-update for unknown user', { socketId: data.socketId })
+              return prev
             }
-            return [
-              ...prev,
-              {
-                socketId: data.socketId,
-                userId: data.userId,
-                userName: data.userName,
-                avatarUrl: data.avatarUrl,
-                cursor: data.cursor,
-              },
-            ]
+            return prev.map((user) =>
+              user.socketId === data.socketId ? { ...user, cursor: data.cursor } : user
+            )
           })
           eventHandlers.current.cursorUpdate?.(data)
         })
 
         socketInstance.on('selection-update', (data) => {
           setPresenceUsers((prev) => {
             const existingIndex = prev.findIndex((user) => user.socketId === data.socketId)
-            if (existingIndex !== -1) {
-              return prev.map((user) =>
-                user.socketId === data.socketId ? { ...user, selection: data.selection } : user
-              )
-            }
-            return [
-              ...prev,
-              {
+            if (existingIndex === -1) {
+              logger.debug('Received selection-update for unknown user', {
                 socketId: data.socketId,
-                userId: data.userId,
-                userName: data.userName,
-                avatarUrl: data.avatarUrl,
-                selection: data.selection,
-              },
-            ]
+              })
+              return prev
+            }
+            return prev.map((user) =>
+              user.socketId === data.socketId ? { ...user, selection: data.selection } : user
+            )
           })
           eventHandlers.current.selectionUpdate?.(data)
         })