add depth check to not crash

Author: icecrasher321

apps/sim/lib/core/utils/display-filters.ts

@@ -4,6 +4,11 @@
  */
 const MAX_STRING_LENGTH = 10000
 
+/**
+ * Maximum recursion depth to prevent stack overflow
+ */
+const MAX_DEPTH = 50
+
 /**
  * Truncates a string if it exceeds the maximum length
  */
@@ -66,6 +71,7 @@ const DISPLAY_FILTERS = [
  * Applies all registered filters recursively to the data structure.
  * Also truncates long strings to prevent database storage issues.
  *
+ *
  * To add a new filter:
  * 1. Create a filter function that checks and transforms a specific data type
  * 2. Add it to the DISPLAY_FILTERS array above
@@ -74,6 +80,11 @@ const DISPLAY_FILTERS = [
  * @returns Filtered data with internal fields removed and long strings truncated
  */
 export function filterForDisplay(data: any): any {
+  const seen = new WeakSet()
+  return filterForDisplayInternal(data, seen, 0)
+}
+
+function filterForDisplayInternal(data: any, seen: WeakSet<object>, depth: number): any {
   // Handle null/undefined
   if (data === null || data === undefined) {
     return data
@@ -84,30 +95,78 @@ export function filterForDisplay(data: any): any {
     return truncateString(data)
   }
 
-  // Return primitives as-is
+  // Return primitives as-is (number, boolean, bigint, symbol, function)
   if (typeof data !== 'object') {
     return data
   }
 
+  // Prevent infinite recursion from circular references
+  if (seen.has(data)) {
+    return '[Circular Reference]'
+  }
+
+  // Prevent stack overflow from very deep nesting
+  if (depth > MAX_DEPTH) {
+    return '[Max Depth Exceeded]'
+  }
+
+  // Handle special object types before adding to seen set
+  // Date objects - convert to ISO string
+  if (data instanceof Date) {
+    return data.toISOString()
+  }
+
+  // Error objects - preserve message and stack
+  if (data instanceof Error) {
+    return {
+      name: data.name,
+      message: truncateString(data.message),
+      stack: data.stack ? truncateString(data.stack) : undefined,
+    }
+  }
+
+  // Buffer or TypedArray - don't serialize full content
+  if (ArrayBuffer.isView(data) || data instanceof ArrayBuffer) {
+    return `[Binary Data: ${data.byteLength} bytes]`
+  }
+
+  // Map - convert to object
+  if (data instanceof Map) {
+    const obj: Record<string, any> = {}
+    for (const [key, value] of data.entries()) {
+      const keyStr = typeof key === 'string' ? key : String(key)
+      obj[keyStr] = filterForDisplayInternal(value, seen, depth + 1)
+    }
+    return obj
+  }
+
+  // Set - convert to array
+  if (data instanceof Set) {
+    return Array.from(data).map((item) => filterForDisplayInternal(item, seen, depth + 1))
+  }
+
+  // Track this object to detect circular references
+  seen.add(data)
+
   // Apply all registered filters
-  const filtered = data
   for (const filterFn of DISPLAY_FILTERS) {
-    const result = filterFn(filtered)
-    if (result !== filtered) {
+    const result = filterFn(data)
+    if (result !== data) {
       // Filter matched and transformed the data
-      return result
+      // Recursively filter the result in case it contains nested objects
+      return filterForDisplayInternal(result, seen, depth + 1)
     }
   }
 
   // No filters matched - recursively filter nested structures
-  if (Array.isArray(filtered)) {
-    return filtered.map(filterForDisplay)
+  if (Array.isArray(data)) {
+    return data.map((item) => filterForDisplayInternal(item, seen, depth + 1))
   }
 
   // Recursively filter object properties
-  const result: any = {}
-  for (const [key, value] of Object.entries(filtered)) {
-    result[key] = filterForDisplay(value)
+  const result: Record<string, any> = {}
+  for (const [key, value] of Object.entries(data)) {
+    result[key] = filterForDisplayInternal(value, seen, depth + 1)
   }
   return result
 }