[BUGFIX] [Hacker Rank] Interview Preparation Kit: Search: Swap Nodes [Algo]. Disallow reassigning function parameters.

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/search/swap_nodes_algo.js

@@ -115,15 +115,6 @@ export function flatTree(root) {
   return output;
 }
 
-export function swapBranch(root) {
-  if (root) {
-    // eslint-disable-next-line no-param-reassign
-    [root.left, root.right] = [root.right, root.left];
-  }
-
-  return root;
-}
-
 export function swapNodes(indexes, queries) {
   const tree = buildTree(indexes);
   const output = [];
@@ -152,7 +143,8 @@ export function swapNodes(indexes, queries) {
 
       if (tLevel % query === 0) {
         for (const node of nodeList) {
-          swapBranch(node);
+          // swap branches
+          [node.left, node.right] = [node.right, node.left];
         }
       }
     }

src/hackerrank/interview_preparation_kit/search/swap_nodes_algo.test.js

@@ -1,13 +1,6 @@
 import { describe, expect, it } from '@jest/globals';
 
-import { Node } from '../../lib/Node.js';
-import {
-  buildTree,
-  flatTree,
-  swapBranch,
-  swapNodes,
-  __INITIAL_LEVEL__
-} from './swap_nodes_algo.js';
+import { buildTree, flatTree, swapNodes } from './swap_nodes_algo.js';
 import TESTCASES from './swap_nodes_algo.testcases.json';
 
 describe('swap_nodes_algo', () => {
@@ -33,28 +26,6 @@ describe('swap_nodes_algo', () => {
     expect(tresult).toStrictEqual(expected);
   });
 
-  it('testswapBranch empty', () => {
-    expect.assertions(1);
-
-    const tInput = null;
-    const tresult = swapBranch(tInput);
-    const expected = null;
-
-    expect(tresult).toStrictEqual(expected);
-  });
-
-  it('testswapBranch', () => {
-    expect.assertions(1);
-
-    const tInput = new Node(__INITIAL_LEVEL__);
-    tInput.left = new Node(2);
-    tInput.right = new Node(3);
-    const tresult = flatTree(swapBranch(tInput));
-    const expected = [3, 1, 2];
-
-    expect(tresult).toStrictEqual(expected);
-  });
-
   it('build tree and flattened tree test cases', () => {
     expect.assertions(4);