Skip to content

Commit 55da752

Browse files
author
David Ferlay
authored
Merge pull request #269 from skilld-labs/storybook_deploy_stage_update
Create new stage + Start storybook only on success
2 parents e53e8bd + 9aa8587 commit 55da752

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.gitlab-ci.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ stages:
3333
- sniffers
3434
- prepare
3535
- deploy
36+
- storybook
3637
- tests
3738
- reports
3839

@@ -196,7 +197,6 @@ prepare:front:
196197
dependencies:
197198
- prepare:back
198199
- prepare:front
199-
allow_failure: false
200200
<<: *runner_tag_selection
201201
<<: *only_branches
202202

@@ -230,7 +230,7 @@ stop_review:
230230
<<: *only_branches
231231

232232
deploy:storybook:
233-
stage: deploy
233+
stage: storybook
234234
environment:
235235
url: https://${CI_ENVIRONMENT_SLUG}-${CI_PROJECT_PATH_SLUG}.${REVIEW_DOMAIN}
236236
name: review/$CI_COMMIT_REF_NAME
@@ -245,8 +245,6 @@ deploy:storybook:
245245
<<: *runner_tag_selection
246246
<<: *only_branches
247247
<<: *only_var_theme
248-
when: always
249-
250248

251249
test:behat:
252250
stage: tests
@@ -271,7 +269,6 @@ test:behat:
271269
when: script_failure
272270
dependencies:
273271
- deploy:review
274-
allow_failure: false
275272
<<: *runner_tag_selection
276273
<<: *only_branches
277274
artifacts:

0 commit comments

Comments
 (0)