Merge pull request #6 from slack-samples/improve-error-handling

feat: improve the error handling logic

Author: WilliamBergamin

listeners/functions/search.py

@@ -60,11 +60,13 @@ def search_step_callback(ack: Ack, inputs: dict, fail: Fail, complete: Complete,
         ]
 
         complete(outputs={"search_result": results})
-    except SlackResponseError as e:
-        logger.error(f"Failed to fetch or parse sample data. Error details: {str(e)}", exc_info=e)
-        fail(error=SEARCH_PROCESSING_ERROR_MSG)
     except Exception as e:
-        logger.error(f"Unexpected error occurred while processing search request: {type(e).__name__} - {str(e)}", exc_info=e)
-        fail(error=SEARCH_PROCESSING_ERROR_MSG)
+        if isinstance(e, SlackResponseError):
+            logger.error(f"Failed to fetch or parse sample data. Error details: {str(e)}", exc_info=e)
+            fail(error=SEARCH_PROCESSING_ERROR_MSG)
+        else:
+            logger.error(
+                f"Unexpected error occurred while processing search request: {type(e).__name__} - {str(e)}", exc_info=e
+            )
     finally:
         ack()

tests/listeners/functions/test_search.py

@@ -123,10 +123,7 @@ def test_search_step_callback_unexpected_exception(self, mock_fetch_sample_data)
             logger=self.mock_logger,
         )
 
-        self.mock_fail.assert_called_once()
-        call_args = self.mock_fail.call_args
-        assert call_args.kwargs["error"] == SEARCH_PROCESSING_ERROR_MSG
-
+        self.mock_fail.assert_not_called()
         self.mock_complete.assert_not_called()
         self.mock_ack.assert_called_once()