Skip to content

Commit 5aabf25

Browse files
caberoscaberos
authored andcommitted
fix team code review comments
1 parent 6aab7b6 commit 5aabf25

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

SoftLayer/managers/ordering.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -747,13 +747,11 @@ def delete_quote(self, quote_id):
747747

748748
return self.client['SoftLayer_Billing_Order_Quote'].deleteQuote(id=quote_id)
749749

750-
def get_all_cancelation(self):
750+
def get_all_cancelation(self, limit=50):
751751
"""returns the all cancelations, completed orders"""
752752

753753
mask = 'mask[id,itemCount,modifyDate,createDate,ticketId,' \
754-
'ticket[assignedUserId,id,attachedHardware[id,hostname,domain],' \
755-
'attachedVirtualGuests[id,hostname,domain],' \
756-
'attachedDedicatedHosts[id,name],serviceProviderResourceId],' \
757-
'status[name,id],user[id,firstName,lastName],' \
758-
'items[billingItem[cancellationDate,categoryCode,pendingCancellationFlag]]]'
759-
return self.client.call('SoftLayer_Billing_Item_Cancellation_Request', 'getAllCancellationRequests', mask=mask)
754+
'ticket[assignedUserId,id,' \
755+
'serviceProviderResourceId],status[name,id],user[id,firstName,lastName]]'
756+
return self.client.call('SoftLayer_Billing_Item_Cancellation_Request', 'getAllCancellationRequests',
757+
mask=mask, limit=limit)

0 commit comments

Comments
 (0)