unit test suspend cloud server

Author: Fernando Ojeda

SoftLayer/managers/ordering.py

@@ -358,10 +358,9 @@ def get_price_id_list(self, package_keyname, item_keynames, core):
             # in which the order is made
             if matching_item['itemCategory']['categoryCode'] != "gpu0":
                 price_id = None
-                category_code = []
                 for price in matching_item['prices']:
                     if not price['locationGroupId']:
-                        price_id = self.save_price_id(category_code, core, price, price_id)
+                        price_id = self.get_item_price_id(core, price, price_id)
             else:
                 # GPU items has two generic prices and they are added to the list
                 # according to the number of gpu items added in the order.
@@ -375,8 +374,9 @@ def get_price_id_list(self, package_keyname, item_keynames, core):
         return prices
 
     @staticmethod
-    def save_price_id(category_code, core, price, price_id):
-        """Save item prices ids"""
+    def get_item_price_id(core, price, price_id):
+        """get item price id"""
+        category_code = []
         if 'capacityRestrictionMinimum' not in price:
             if price['categories'][0]['categoryCode'] not in category_code:
                 category_code.append(price['categories'][0]['categoryCode'])

tests/managers/ordering_tests.py

@@ -548,3 +548,28 @@ def test_location_groud_id_empty(self):
 
         list_mock.assert_called_once_with('PACKAGE_KEYNAME', mask='id, itemCategory, keyName, prices[categories]')
         self.assertEqual([price1['id'], price2['id']], prices)
+
+    def test_get_item_price_id_without_capacity_restriction(self):
+        category1 = {'categoryCode': 'cat1'}
+        price1 = {'id': 1234, 'locationGroupId': '', 'categories': [category1]}
+
+        with mock.patch.object(self.ordering, 'get_item_price_id') as list_mock:
+            list_mock.return_value = [price1]
+
+            prices = self.ordering.get_item_price_id("8", price1)
+
+        list_mock.assert_called_once_with("8", price1)
+        self.assertEqual(1234, prices[0]['id'])
+
+    def test_get_item_price_id_with_capacity_restriction(self):
+        category1 = {'categoryCode': 'cat1'}
+        price1 = {'id': 1234, 'locationGroupId': '', "capacityRestrictionMaximum": "16",
+                  "capacityRestrictionMinimum": "1", 'categories': [category1]}
+
+        with mock.patch.object(self.ordering, 'get_item_price_id') as list_mock:
+            list_mock.return_value = [price1]
+
+            prices = self.ordering.get_item_price_id("8", price1)
+
+        list_mock.assert_called_once_with("8", price1)
+        self.assertEqual(1234, prices[0]['id'])