Merge pull request #1697 from allmightyspiff/issues1658

Fixed an issue with printing tables that contained empty items

Author: allmightyspiff

SoftLayer/CLI/formatting.py

@@ -72,7 +72,12 @@ def format_prettytable(table, fmt='table'):
     """Converts SoftLayer.CLI.formatting.Table instance to a prettytable."""
     for i, row in enumerate(table.rows):
         for j, item in enumerate(row):
-            table.rows[i][j] = format_output(item)
+            # Issue when adding items that evaulate to None (like empty lists) for Rich Tables
+            # so we just cast those to a str
+            if item:
+                table.rows[i][j] = format_output(item)
+            else:
+                table.rows[i][j] = str(item)
     ptable = table.prettytable(fmt)
     return ptable
 

tests/CLI/helper_tests.py

@@ -484,3 +484,13 @@ def test_format_api_list_with_none_value(self):
 
         self.assertIsInstance(result, formatting.Table)
         self.assertEqual(result.columns, ['key'])
+
+    def test_format_api_list_with_empty_array(self):
+        result = formatting.iter_to_table([{'id': 130224450, 'activeTickets': []}])
+        self.assertIsInstance(result, formatting.Table)
+        self.assertIn('id', result.columns)
+        self.assertIn('activeTickets', result.columns)
+        formatted = formatting.format_output(result, "table")
+        # No good ways to test whats actually in a Rich.Table without going through the hassel of
+        # printing it out. As long as this didn't throw and exception it should be fine.
+        self.assertEqual(formatted.row_count, 1)