Skip to content

Commit d04e466

Browse files
caberoscaberos
authored andcommitted
fix the team code review comments
1 parent 2b0a052 commit d04e466

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

SoftLayer/CLI/firewall/monitoring.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ def cli(env, identifier):
4343
table.add_row(['Name', _firewall['networkGateway']['name']])
4444
table.add_row(['Stard Date', last_month.strftime('%Y-%m-%d')])
4545
table.add_row(['End Date', end.strftime('%Y-%m-%d')])
46-
table.add_row(['Out', public_out])
47-
table.add_row(['In', public_in])
48-
table.add_row(['Total', public_out + public_in])
46+
table.add_row(['Out', formatting.b_to_gb(public_out)])
47+
table.add_row(['In', formatting.b_to_gb(public_in)])
48+
table.add_row(['Total', formatting.b_to_gb(public_out + public_in)])
4949
table.add_row(['Status', _firewall['networkGateway']['status']['name']])
5050

5151
env.fout(table)

SoftLayer/managers/firewall.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,4 +336,4 @@ def get_summary(self, identifier, start_date, end_date):
336336
}]
337337

338338
return self.client['Metric_Tracking_Object'].getSummaryData(start_date,
339-
end_date, body, 1800, id=identifier)
339+
end_date, body, 86400, id=identifier)

0 commit comments

Comments
 (0)