Skip to content

Commit d511e92

Browse files
caberoscaberos
authored andcommitted
fix team code review comments
1 parent 55108c5 commit d511e92

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

SoftLayer/CLI/autoscale/create.py

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,15 @@
4040
@helpers.multi_option('--disk', required=True, prompt=True, help="Disk sizes")
4141
@environment.pass_env
4242
def cli(env, **args):
43-
"""Order/Create a scale group."""
43+
"""Order/Create a scale group.
44+
45+
E.g.
46+
47+
'slcli autoscale create --name test --cooldown 3600 --min 1 --max 2 -o CENTOS_7_64 --datacenter dal10
48+
--termination-policy 2 -H testvs -D test.com --cpu 2 --memory 1024 --policy-relative absolute
49+
--policy-name policytest --policy-amount 3 --regional 102 --disk 25 --disk 30 --disk 25'
50+
51+
"""
4452
scale = AutoScaleManager(env.client)
4553
network = SoftLayer.NetworkManager(env.client)
4654

@@ -67,6 +75,8 @@ def cli(env, **args):
6775
block = []
6876
number_disk = 0
6977
for guest_disk in args['disk']:
78+
if number_disk == 1:
79+
number_disk = 2
7080
disks = {'diskImage': {'capacity': guest_disk}, 'device': number_disk}
7181
block.append(disks)
7282
number_disk += 1
@@ -114,14 +124,16 @@ def cli(env, **args):
114124
result = scale.create(order)
115125

116126
table = formatting.KeyValueTable(['name', 'value'])
127+
vsi_table = formatting.KeyValueTable(['Id', 'Domain', 'Hostmane'])
117128
table.align['name'] = 'r'
118129
table.align['value'] = 'l'
119130
table.add_row(['Id', result['id']])
120131
table.add_row(['Created', result['createDate']])
121132
table.add_row(['Name', result['name']])
122-
table.add_row(['Virtual Guest Id', result['virtualGuestMembers'][0]['virtualGuest']['id']])
123-
table.add_row(['Virtual Guest domain', result['virtualGuestMembers'][0]['virtualGuest']['domain']])
124-
table.add_row(['Virtual Guest hostname', result['virtualGuestMembers'][0]['virtualGuest']['hostname']])
133+
for vsi in result['virtualGuestMembers']:
134+
vsi_table.add_row([vsi['virtualGuest']['id'], vsi['virtualGuest']['domain'], vsi['virtualGuest']['hostname']])
135+
136+
table.add_row(['VirtualGuests', vsi_table])
125137
output = table
126138

127139
env.fout(output)

0 commit comments

Comments
 (0)