Skip to content

Commit dec28cb

Browse files
caberoscaberos
authored andcommitted
fix the team code review commens
1 parent cce8e11 commit dec28cb

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

SoftLayer/CLI/vpn/ipsec/order.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import SoftLayer
77

88
from SoftLayer.CLI import environment
9+
from SoftLayer.CLI import exceptions
910
from SoftLayer.CLI import formatting
1011

1112

@@ -17,6 +18,10 @@ def cli(env, datacenter):
1718

1819
ipsec_manager = SoftLayer.IPSECManager(env.client)
1920

21+
if not (env.skip_confirmations or formatting.confirm(
22+
"This action will incur charges on your account. Continue?")):
23+
raise exceptions.CLIAbort('Aborting ipsec order.')
24+
2025
result = ipsec_manager.order(datacenter, ['IPSEC_STANDARD'])
2126

2227
table = formatting.KeyValueTable(['Name', 'Value'])

tests/managers/ipsec_tests.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
import SoftLayer
1010
from SoftLayer.exceptions import SoftLayerAPIError
11+
from SoftLayer.fixtures import SoftLayer_Product_Order
12+
from SoftLayer.fixtures import SoftLayer_Product_Package
13+
1114
from SoftLayer import testing
1215

1316

@@ -299,3 +302,20 @@ def test_update_tunnel_context(self):
299302
'phaseTwoKeylife': 240,
300303
'phaseTwoPerfectForwardSecrecy': 1},),
301304
identifier=445)
305+
306+
def test_order(self):
307+
_mock = self.set_mock('SoftLayer_Product_Package', 'getItems')
308+
_mock.return_value = SoftLayer_Product_Package.getItems_IPSEC
309+
310+
_mock = self.set_mock('SoftLayer_Product_Order', 'placeOrder')
311+
_mock.return_value = SoftLayer_Product_Order.ipsec_placeOrder
312+
result = self.ipsec.order('dal13', ['IPSEC_STANDARD'])
313+
order = {
314+
'orderDate': '2022-07-14T16:09:08-06:00',
315+
'orderId': 123456, 'placedOrder': {'items': [
316+
{'categoryCode': 'network_tunnel',
317+
'description': 'IPSEC - Standard',
318+
'id': 931479898,
319+
'itemId': 1092,
320+
'itemPriceId': '2048'}]}}
321+
self.assertEqual(result, order)

0 commit comments

Comments
 (0)