Skip to content

Commit a604664

Browse files
Remove supported_transaction_version property (#1088)
* removed supported_transaction_version * lint * Update migration guide --------- Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
1 parent 40bad69 commit a604664

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

docs/migration_guide.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ Changes in the :class:`~starknet_py.net.full_node_client.FullNodeClient`:
5858
9. :class:`FunctionInvocation` has a new required field ``execution_resources``.
5959
10. :class:`ResourcePrice` field ``price_in_strk`` has been renamed to ``price_in_fri`` and has now become required.
6060
11. :class:`ResourceLimits` class has been renamed to :class:`ResourceBounds`.
61+
12. :class:`~starknet_py.net.account.base_account.BaseAccount` and :class:`~starknet_py.net.account.account.Account` property ``supported_transaction_version`` has been removed.
6162

6263
0.19.0 Minor changes
6364
--------------------

starknet_py/net/account/account.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import dataclasses
22
import json
3-
import warnings
43
from collections import OrderedDict
54
from typing import Any, Dict, Iterable, List, Optional, Tuple, Union
65

@@ -125,14 +124,6 @@ async def cairo_version(self) -> int:
125124
def client(self) -> Client:
126125
return self._client
127126

128-
@property
129-
def supported_transaction_version(self) -> int:
130-
warnings.warn(
131-
"Property supported_transaction_version is deprecated and will be removed in the future.",
132-
category=DeprecationWarning,
133-
)
134-
return 1
135-
136127
async def _get_max_fee(
137128
self,
138129
transaction: AccountTransaction,

starknet_py/net/account/base_account.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,6 @@ def client(self) -> Client:
5151
Get the Client used by the Account.
5252
"""
5353

54-
@property
55-
@abstractmethod
56-
def supported_transaction_version(self) -> int:
57-
"""
58-
Get transaction version supported by the account.
59-
60-
.. deprecated :: 0.15.0
61-
Property supported_transaction_version is deprecated and will be removed in the future.
62-
"""
63-
6454
@abstractmethod
6555
async def get_nonce(
6656
self,

0 commit comments

Comments
 (0)