From 16bde944f53a8d48d2da90b236f0fa487b52a9c9 Mon Sep 17 00:00:00 2001 From: Illia Aihistov Date: Thu, 20 Feb 2025 15:02:29 +0200 Subject: [PATCH] Update Solid Lints --- .../example/lib/controls_overlay.dart | 4 +++- .../example/lib/multiple_tab.dart | 7 ++++--- .../example/lib/single_tab.dart | 17 ++++++++--------- .../example/lib/vlc_player_with_controls.dart | 19 ++++++++++--------- .../lib/src/flutter_vlc_player.dart | 4 ++-- .../lib/src/vlc_player_controller.dart | 5 +++-- .../lib/src/vlc_player_value.dart | 1 + flutter_vlc_player/pigeons/messages.dart | 2 +- .../lib/src/enums/hardware_acceleration.dart | 2 +- .../lib/src/enums/media_event_type.dart | 2 +- .../lib/src/enums/renderer_event_type.dart | 2 +- .../lib/src/events/media_event.dart | 2 +- .../lib/src/events/renderer_event.dart | 2 +- .../method_channel_vlc_player.dart | 4 +++- .../vlc_player_platform_interface.dart | 3 ++- 15 files changed, 42 insertions(+), 34 deletions(-) diff --git a/flutter_vlc_player/example/lib/controls_overlay.dart b/flutter_vlc_player/example/lib/controls_overlay.dart index f3e9c882..fda93dc2 100644 --- a/flutter_vlc_player/example/lib/controls_overlay.dart +++ b/flutter_vlc_player/example/lib/controls_overlay.dart @@ -19,12 +19,13 @@ class ControlsOverlay extends StatelessWidget { }); @override + // ignore: cyclomatic_complexity Widget build(BuildContext context) { return AnimatedSwitcher( duration: const Duration(milliseconds: 50), reverseDuration: const Duration(milliseconds: 200), child: Builder( - builder: (ctx) { + builder: (_) { if (controller.value.isEnded || controller.value.hasError) { return Center( child: FittedBox( @@ -113,6 +114,7 @@ class ControlsOverlay extends StatelessWidget { } Future _pause() async { + // ignore: prefer_early_return if (controller.value.isPlaying) { await controller.pause(); } diff --git a/flutter_vlc_player/example/lib/multiple_tab.dart b/flutter_vlc_player/example/lib/multiple_tab.dart index bea10454..cdf5b9ce 100644 --- a/flutter_vlc_player/example/lib/multiple_tab.dart +++ b/flutter_vlc_player/example/lib/multiple_tab.dart @@ -10,6 +10,7 @@ class MultipleTab extends StatefulWidget { class _MultipleTabState extends State { static const _heightWithControls = 400.0; static const _heightWithoutControls = 300.0; + static const _networkCachingTime = 2000; List controllers = []; @@ -31,7 +32,7 @@ class _MultipleTabState extends State { autoPlay: false, options: VlcPlayerOptions( advanced: VlcAdvancedOptions([ - VlcAdvancedOptions.networkCaching(2000), + VlcAdvancedOptions.networkCaching(_networkCachingTime), ]), rtp: VlcRtpOptions([ VlcRtpOptions.rtpOverRtsp(true), @@ -46,7 +47,7 @@ class _MultipleTabState extends State { Widget build(BuildContext context) { return ListView.separated( itemCount: controllers.length, - separatorBuilder: (_, index) { + separatorBuilder: (_, __) { return const Divider(height: 5, thickness: 5, color: Colors.grey); }, itemBuilder: (_, index) { @@ -64,10 +65,10 @@ class _MultipleTabState extends State { @override Future dispose() async { - super.dispose(); for (final controller in controllers) { await controller.stopRendererScanning(); await controller.dispose(); } + super.dispose(); } } diff --git a/flutter_vlc_player/example/lib/single_tab.dart b/flutter_vlc_player/example/lib/single_tab.dart index 81c262c1..23f3e891 100644 --- a/flutter_vlc_player/example/lib/single_tab.dart +++ b/flutter_vlc_player/example/lib/single_tab.dart @@ -1,5 +1,7 @@ +// ignore_for_file: cyclomatic_complexity import 'dart:io'; +import 'package:flutter/foundation.dart'; import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; import 'package:flutter_vlc_player/flutter_vlc_player.dart'; @@ -19,7 +21,7 @@ class _SingleTabState extends State { final _key = GlobalKey(); - // ignore: avoid-late-keyword + // ignore: avoid_late_keyword late final VlcPlayerController _controller; // @@ -120,7 +122,10 @@ class _SingleTabState extends State { await _controller.startRendererScanning(); }); _controller.addOnRendererEventListener((type, id, name) { - debugPrint('OnRendererEventListener $type $id $name'); + // ignore: prefer_early_return + if (!kReleaseMode) { + debugPrint('OnRendererEventListener $type $id $name'); + } }); } @@ -258,15 +263,9 @@ class _SingleTabState extends State { @override Future dispose() async { - super.dispose(); await _controller.stopRecording(); await _controller.stopRendererScanning(); await _controller.dispose(); + super.dispose(); } } - -class MyClass { - final int _myField = 0; - - int get myField => _myField; -} diff --git a/flutter_vlc_player/example/lib/vlc_player_with_controls.dart b/flutter_vlc_player/example/lib/vlc_player_with_controls.dart index 406e1bbd..a34ffcd5 100644 --- a/flutter_vlc_player/example/lib/vlc_player_with_controls.dart +++ b/flutter_vlc_player/example/lib/vlc_player_with_controls.dart @@ -1,3 +1,4 @@ +// ignore_for_file: prefer_early_return, function_lines_of_code import 'dart:typed_data'; import 'package:flutter/material.dart'; @@ -36,7 +37,7 @@ class VlcPlayerWithControlsState extends State { final double initSnapshotRightPosition = 10; final double initSnapshotBottomPosition = 10; - // ignore: avoid-late-keyword + // ignore: avoid_late_keyword late VlcPlayerController _controller; // @@ -363,7 +364,7 @@ class VlcPlayerWithControlsState extends State { IconButton( icon: const Icon(Icons.fullscreen), color: Colors.white, - // ignore: no-empty-block + // ignore: no_empty_block onPressed: () {}, ), ], @@ -456,7 +457,7 @@ class VlcPlayerWithControlsState extends State { if (!mounted) return; final selectedSubId = await showDialog( context: context, - builder: (BuildContext context) { + builder: (BuildContext _) { return AlertDialog( title: const Text('Select Subtitle'), content: SizedBox( @@ -502,7 +503,7 @@ class VlcPlayerWithControlsState extends State { if (!mounted) return; final selectedAudioTrackId = await showDialog( context: context, - builder: (BuildContext context) { + builder: (BuildContext _) { return AlertDialog( title: const Text('Select Audio'), content: SizedBox( @@ -546,7 +547,7 @@ class VlcPlayerWithControlsState extends State { if (!mounted) return; final selectedCastDeviceName = await showDialog( context: context, - builder: (BuildContext context) { + builder: (BuildContext _) { return AlertDialog( title: const Text('Display Devices'), content: SizedBox( @@ -596,7 +597,7 @@ class VlcPlayerWithControlsState extends State { if (!mounted) return; - // ignore: avoid-non-null-assertion + // ignore: avoid_non_null_assertion Overlay.of(context).insert(_overlayEntry!); } @@ -617,7 +618,7 @@ class VlcPlayerWithControlsState extends State { _overlayEntry = null; await showDialog( context: context, - builder: (ctx) { + builder: (_) { return AlertDialog( contentPadding: EdgeInsets.zero, content: Image.memory(snapshot), @@ -633,7 +634,7 @@ class VlcPlayerWithControlsState extends State { right -= dragUpdateDetails.delta.dx; _overlayEntry?.markNeedsBuild(); }, - onHorizontalDragEnd: (dragEndDetails) { + onHorizontalDragEnd: (_) { if ((initSnapshotRightPosition - right).abs() >= _overlayWidth) { _overlayEntry?.remove(); _overlayEntry = null; @@ -642,7 +643,7 @@ class VlcPlayerWithControlsState extends State { _overlayEntry?.markNeedsBuild(); } }, - onVerticalDragEnd: (dragEndDetails) { + onVerticalDragEnd: (_) { if ((initSnapshotBottomPosition - bottom).abs() >= _overlayWidth) { _overlayEntry?.remove(); diff --git a/flutter_vlc_player/lib/src/flutter_vlc_player.dart b/flutter_vlc_player/lib/src/flutter_vlc_player.dart index c2e760b9..81776c00 100644 --- a/flutter_vlc_player/lib/src/flutter_vlc_player.dart +++ b/flutter_vlc_player/lib/src/flutter_vlc_player.dart @@ -2,7 +2,7 @@ import 'package:flutter/widgets.dart'; import 'package:flutter_vlc_player/src/vlc_player_controller.dart'; import 'package:flutter_vlc_player/src/vlc_player_platform.dart'; -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name class VlcPlayer extends StatefulWidget { final VlcPlayerController controller; final double aspectRatio; @@ -36,7 +36,7 @@ class VlcPlayer extends StatefulWidget { class _VlcPlayerState extends State { bool _isInitialized = false; - //ignore: avoid-late-keyword + //ignore: avoid_late_keyword late VoidCallback _listener; _VlcPlayerState() { diff --git a/flutter_vlc_player/lib/src/vlc_player_controller.dart b/flutter_vlc_player/lib/src/vlc_player_controller.dart index 8b2a025c..3681c401 100644 --- a/flutter_vlc_player/lib/src/vlc_player_controller.dart +++ b/flutter_vlc_player/lib/src/vlc_player_controller.dart @@ -63,7 +63,7 @@ class VlcPlayerController extends ValueNotifier { bool? _isReadyToInitialize; /// The viewId for this controller - // ignore: avoid-late-keyword + // ignore: avoid_late_keyword late int _viewId; /// List of onInit listeners @@ -351,9 +351,9 @@ class VlcPlayerController extends ValueNotifier { _onRendererEventListeners.clear(); _lifeCycleObserver?.dispose(); _isDisposed = true; - super.dispose(); // await vlcPlayerPlatform.dispose(_viewId); + super.dispose(); } /// Notify onInit callback & all registered listeners @@ -953,6 +953,7 @@ class VlcPlayerController extends ValueNotifier { '$functionName() was called on an uninitialized VlcPlayerController.', ); } + // ignore: prefer_early_return if (_isDisposed) { throw Exception( '$functionName() was called on a disposed VlcPlayerController.', diff --git a/flutter_vlc_player/lib/src/vlc_player_value.dart b/flutter_vlc_player/lib/src/vlc_player_value.dart index f45c61f7..9c0e2e14 100644 --- a/flutter_vlc_player/lib/src/vlc_player_value.dart +++ b/flutter_vlc_player/lib/src/vlc_player_value.dart @@ -153,6 +153,7 @@ class VlcPlayerValue { /// Returns a new instance that has the same values as this current instance, /// except for any overrides passed in as arguments to [copyWidth]. + // ignore: number_of_parameters VlcPlayerValue copyWith({ Duration? duration, Size? size, diff --git a/flutter_vlc_player/pigeons/messages.dart b/flutter_vlc_player/pigeons/messages.dart index a139e950..0abf7743 100644 --- a/flutter_vlc_player/pigeons/messages.dart +++ b/flutter_vlc_player/pigeons/messages.dart @@ -1,6 +1,6 @@ import 'package:pigeon/pigeon_lib.dart'; -//ignore: prefer-match-file-name +//ignore: prefer_match_file_name class ViewMessage { int? viewId; } diff --git a/flutter_vlc_player_platform_interface/lib/src/enums/hardware_acceleration.dart b/flutter_vlc_player_platform_interface/lib/src/enums/hardware_acceleration.dart index e9dd27b3..2b3d2751 100644 --- a/flutter_vlc_player_platform_interface/lib/src/enums/hardware_acceleration.dart +++ b/flutter_vlc_player_platform_interface/lib/src/enums/hardware_acceleration.dart @@ -1,2 +1,2 @@ -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name enum HwAcc { auto, disabled, decoding, full } diff --git a/flutter_vlc_player_platform_interface/lib/src/enums/media_event_type.dart b/flutter_vlc_player_platform_interface/lib/src/enums/media_event_type.dart index a3b97250..e0723e7d 100644 --- a/flutter_vlc_player_platform_interface/lib/src/enums/media_event_type.dart +++ b/flutter_vlc_player_platform_interface/lib/src/enums/media_event_type.dart @@ -1,4 +1,4 @@ -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name enum VlcMediaEventType { opening, playing, diff --git a/flutter_vlc_player_platform_interface/lib/src/enums/renderer_event_type.dart b/flutter_vlc_player_platform_interface/lib/src/enums/renderer_event_type.dart index baf1d46e..49c72002 100644 --- a/flutter_vlc_player_platform_interface/lib/src/enums/renderer_event_type.dart +++ b/flutter_vlc_player_platform_interface/lib/src/enums/renderer_event_type.dart @@ -1,2 +1,2 @@ -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name enum VlcRendererEventType { attached, detached, unknown } diff --git a/flutter_vlc_player_platform_interface/lib/src/events/media_event.dart b/flutter_vlc_player_platform_interface/lib/src/events/media_event.dart index 50b33824..ff81a20e 100644 --- a/flutter_vlc_player_platform_interface/lib/src/events/media_event.dart +++ b/flutter_vlc_player_platform_interface/lib/src/events/media_event.dart @@ -2,7 +2,7 @@ import 'dart:ui'; import 'package:flutter_vlc_player_platform_interface/src/enums/media_event_type.dart'; -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name class VlcMediaEvent { /// The type of the event. final VlcMediaEventType mediaEventType; diff --git a/flutter_vlc_player_platform_interface/lib/src/events/renderer_event.dart b/flutter_vlc_player_platform_interface/lib/src/events/renderer_event.dart index c0b61459..c559a146 100644 --- a/flutter_vlc_player_platform_interface/lib/src/events/renderer_event.dart +++ b/flutter_vlc_player_platform_interface/lib/src/events/renderer_event.dart @@ -1,6 +1,6 @@ import 'package:flutter_vlc_player_platform_interface/src/enums/renderer_event_type.dart'; -// ignore: prefer-match-file-name +// ignore: prefer_match_file_name class VlcRendererEvent { /// The type of the event. final VlcRendererEventType eventType; diff --git a/flutter_vlc_player_platform_interface/lib/src/method_channel/method_channel_vlc_player.dart b/flutter_vlc_player_platform_interface/lib/src/method_channel/method_channel_vlc_player.dart index 80a085ff..15d8c4ba 100644 --- a/flutter_vlc_player_platform_interface/lib/src/method_channel/method_channel_vlc_player.dart +++ b/flutter_vlc_player_platform_interface/lib/src/method_channel/method_channel_vlc_player.dart @@ -47,6 +47,7 @@ class MethodChannelVlcPlayer extends VlcPlayerPlatform { return _api.create(message); } + // ignore: proper_super_calls @override Future dispose(int viewId) async { return _api.dispose(ViewMessage()..viewId = viewId); @@ -76,7 +77,7 @@ class MethodChannelVlcPlayer extends VlcPlayerPlatform { : PlatformViewLink( viewType: viewType, surfaceFactory: ( - BuildContext context, + BuildContext _, PlatformViewController controller, ) { return AndroidViewSurface( @@ -110,6 +111,7 @@ class MethodChannelVlcPlayer extends VlcPlayerPlatform { } @override + // ignore: cyclomatic_complexity Stream mediaEventsFor(int viewId) { return _mediaEventChannelFor(viewId).receiveBroadcastStream().map(( dynamic event, diff --git a/flutter_vlc_player_platform_interface/lib/src/platform_interface/vlc_player_platform_interface.dart b/flutter_vlc_player_platform_interface/lib/src/platform_interface/vlc_player_platform_interface.dart index 31521a64..e0270d38 100644 --- a/flutter_vlc_player_platform_interface/lib/src/platform_interface/vlc_player_platform_interface.dart +++ b/flutter_vlc_player_platform_interface/lib/src/platform_interface/vlc_player_platform_interface.dart @@ -6,7 +6,7 @@ import 'package:flutter_vlc_player_platform_interface/flutter_vlc_player_platfor import 'package:flutter_vlc_player_platform_interface/src/method_channel/method_channel_vlc_player.dart'; import 'package:plugin_platform_interface/plugin_platform_interface.dart'; -// ignore_for_file: prefer-match-file-name +// ignore_for_file: prefer_match_file_name /// The interface that implementations of vlc must implement. /// @@ -32,6 +32,7 @@ abstract class VlcPlayerPlatform extends PlatformInterface { /// Constructs a VlcPlayerPlatform. VlcPlayerPlatform() : super(token: _token); + // ignore: avoid_returning_widgets /// Returns a widget displaying the video. Widget buildView( PlatformViewCreatedCallback onPlatformViewCreated, {