Skip to content

Commit 0fd3e48

Browse files
update formating, linting, and some dependencies (#1117)
Co-authored-by: Amir Hossein Hashemi <87268103+amirhhashemi@users.noreply.github.com>
1 parent a8f632f commit 0fd3e48

File tree

245 files changed

+5137
-5539
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

245 files changed

+5137
-5539
lines changed

.eslintrc.json

Lines changed: 0 additions & 45 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/BUGS.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
name: "Bug Report 🪲"
22
description: Report an issue or possible bug with the functionality of the Solid docs website. (Not related to the content of the site.)
33
title: "[Bug]: "
4-
labels: [
5-
"bug",
6-
"pending review"
7-
]
8-
assignees:
9-
- danieljcafonso
10-
- atilafassina
4+
labels: ["bug", "pending review"]
5+
assignees:
6+
- danieljcafonso
7+
- atilafassina
118

129
body:
1310
- type: textarea
@@ -25,21 +22,21 @@ body:
2522
description: Please indicate on which page(s) the issue occurs.
2623
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2724
validations:
28-
required: true
25+
required: true
2926
- type: textarea
3027
id: expected
3128
attributes:
3229
label: "🤔 Expected Behavior"
3330
description: Please describe what the expected behavior should be.
34-
placeholder: When on this page, I expected . . .
31+
placeholder: When on this page, I expected . . .
3532
validations:
3633
required: true
3734
- type: textarea
3835
id: current
3936
attributes:
4037
label: "👀 Current Behavior"
4138
description: Please describe what the current behavior is.
42-
placeholder: But instead, on this page I'm noticing . . .
39+
placeholder: But instead, on this page I'm noticing . . .
4340
validations:
4441
required: true
4542
- type: input

.github/ISSUE_TEMPLATE/CONTENT.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
name: "Content Report 📄"
22
title: "[Content]:"
33
description: Report an issue with existing content.
4-
labels: [
5-
"improve documentation", "pending review"
6-
]
7-
assignees:
8-
- ladybluenotes
4+
labels: ["improve documentation", "pending review"]
5+
assignees:
6+
- ladybluenotes
97
body:
108
- type: markdown
119
attributes:
@@ -25,19 +23,19 @@ body:
2523
description: Please provide the URL of the page(s) affected.
2624
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2725
validations:
28-
required: true
26+
required: true
2927
- type: textarea
3028
id: generalDesc
3129
attributes:
3230
label: "📋 Description of content that is out-of-date or incorrect"
3331
description: Let us know what's wrong!
3432
placeholder: "..."
3533
validations:
36-
required: true
34+
required: true
3735
- type: textarea
3836
id: incorrectContent
3937
attributes:
4038
label: "🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)"
4139
description: If you are reporting incorrect content or code samples, you can also attach a reproduction in stackblitz.
4240
validations:
43-
required: false
41+
required: false

.github/ISSUE_TEMPLATE/OTHER.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
name: "Other Report 🌐"
22
title: "[Other]:"
33
description: Report something else we should know about the docs site!
4-
labels: [
5-
"pending review"
6-
]
4+
labels: ["pending review"]
75
body:
86
- type: textarea
97
id: issue
@@ -12,4 +10,4 @@ body:
1210
description: Please describe the problem with the documentation in detail.
1311
placeholder: "..."
1412
validations:
15-
required: true
13+
required: true

.github/ISSUE_TEMPLATE/REQUEST.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
name: "Request 💡"
22
title: "[Request]:"
33
description: Share an idea.
4-
labels: [
5-
"request", "pending review"
6-
]
4+
labels: ["request", "pending review"]
75
assignees:
8-
- ladybluenotes
6+
- ladybluenotes
97
body:
108
- type: markdown
119
attributes:
@@ -14,7 +12,7 @@ body:
1412
id: request-topic
1513
attributes:
1614
label: "What is this request related to?"
17-
options:
15+
options:
1816
- Request
1917
- Styling
2018
- Feature
@@ -27,20 +25,20 @@ body:
2725
description: Please provide the URL of the page(s) or section this idea is related to.
2826
placeholder: https://docs.solidjs.com/concepts/intro-to-reactivity
2927
validations:
30-
required: false
28+
required: false
3129
- type: textarea
3230
id: generalDesc
3331
attributes:
3432
label: "📋 General description or bullet points"
3533
description: Please provide a general description or bullet points about what you would like to see added.
3634
placeholder: "..."
3735
validations:
38-
required: true
36+
required: true
3937
- type: textarea
4038
id: example
4139
attributes:
4240
label: "🖥️ Reproduction of code samples in StackBlitz"
4341
description: If you would like to suggest code samples please attach a working reproduction.
4442
placeholder: "..."
4543
validations:
46-
required: false
44+
required: false

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ blank_issues_enabled: true
22
contact_links:
33
- name: Support & Community 💁
44
url: https://discord.com/invite/solidjs
5-
about: 'This issue tracker is not for support questions. Our Discord server hosts the community of Solid users. Come join us to discuss Solid or find assistance!'
5+
about: "This issue tracker is not for support questions. Our Discord server hosts the community of Solid users. Come join us to discuss Solid or find assistance!"

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
- [ ] This PR references an issue (except for typos, broken links, or other minor problems)
55

66
### Description(required)
7+
78
<!-- Provide a detailed description of the changes in this PR. Why is it necessary, and what does it do? -->
89

910
### Related issues & labels

.github/actions/install/action.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Install Tools & Dependencies
2+
description: Installs pnpm, Node.js & package dependencies
3+
4+
runs:
5+
using: composite
6+
steps:
7+
- name: Setup pnpm
8+
uses: pnpm/action-setup@v4
9+
with:
10+
version: 9
11+
run_install: false
12+
13+
- name: Setup Node.js
14+
uses: actions/setup-node@v4
15+
with:
16+
node-version: 20
17+
cache: pnpm
18+
19+
- name: Install dependencies
20+
run: pnpm install
21+
shell: bash

.github/workflows/format.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Install Tools & Dependencies
2+
description: Installs pnpm, Node.js & package dependencies
3+
4+
runs:
5+
using: composite
6+
steps:
7+
- name: Setup pnpm
8+
uses: pnpm/action-setup@v4
9+
with:
10+
version: 9
11+
run_install: false
12+
13+
- name: Setup Node.js
14+
uses: actions/setup-node@v4
15+
with:
16+
node-version: 20
17+
cache: pnpm
18+
19+
- name: Install dependencies
20+
run: pnpm install
21+
shell: bash

.github/workflows/static_checks.yml

Lines changed: 18 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -2,70 +2,37 @@ name: 🔍 Lint / Type Checks
22

33
on:
44
push:
5-
branches: [main]
5+
branches:
6+
- main
7+
68
pull_request:
7-
branches: [main]
9+
branches:
10+
- main
811

912
jobs:
10-
setup:
11-
runs-on: ubuntu-latest
12-
steps:
13-
- uses: actions/checkout@v4
14-
- uses: pnpm/action-setup@v4
15-
with:
16-
version: 9
17-
- uses: actions/setup-node@v4
18-
with:
19-
node-version: "20"
20-
cache: "pnpm"
21-
- run: pnpm i
22-
- uses: actions/cache/save@v4
23-
with:
24-
path: |
25-
node_modules
26-
~/.pnpm-store
27-
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
28-
2913
typecheck:
30-
needs: setup
3114
runs-on: ubuntu-latest
3215
steps:
33-
- uses: actions/checkout@v4
34-
- uses: pnpm/action-setup@v4
35-
with:
36-
version: 9
37-
- uses: actions/setup-node@v4
38-
with:
39-
node-version: "20"
40-
cache: "pnpm"
41-
- uses: actions/cache/restore@v4
42-
with:
43-
path: |
44-
node_modules
45-
~/.pnpm-store
46-
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
16+
- name: Check out code
17+
uses: actions/checkout@v4
18+
19+
- name: Install tools & dependencies
20+
uses: ./.github/actions/install
21+
4722
- name: Generate virtual modules
4823
run: pnpm sync
24+
4925
- name: TypeScript check
5026
run: pnpm check:types
5127

5228
lint:
53-
needs: setup
5429
runs-on: ubuntu-latest
5530
steps:
56-
- uses: actions/checkout@v4
57-
- uses: pnpm/action-setup@v4
58-
with:
59-
version: 9
60-
- uses: actions/setup-node@v4
61-
with:
62-
node-version: "20"
63-
cache: "pnpm"
64-
- uses: actions/cache/restore@v4
65-
with:
66-
path: |
67-
node_modules
68-
~/.pnpm-store
69-
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
31+
- name: Check out code
32+
uses: actions/checkout@v4
33+
34+
- name: Install tools & dependencies
35+
uses: ./.github/actions/install
36+
7037
- name: ESLint check
7138
run: pnpm check:lint

0 commit comments

Comments
 (0)