remove ERC2981 revert case

ItsNickBarry · ItsNickBarry · commit ab46879e0ca9 · 2022-10-28T20:21:50.000-06:00
diff --git a/abi/ERC2981.json b/abi/ERC2981.json
@@ -1,9 +1,4 @@
 [
-  {
-    "inputs": [],
-    "name": "ERC2981Internal__RoyaltyExceedsMax",
-    "type": "error"
-  },
   {
     "inputs": [
       {
diff --git a/abi/ERC2981Internal.json b/abi/ERC2981Internal.json
diff --git a/abi/IERC2981.json b/abi/IERC2981.json
@@ -1,9 +1,4 @@
 [
-  {
-    "inputs": [],
-    "name": "ERC2981Internal__RoyaltyExceedsMax",
-    "type": "error"
-  },
   {
     "inputs": [
       {
diff --git a/abi/IERC2981Internal.json b/abi/IERC2981Internal.json
diff --git a/contracts/interfaces/IERC2981Internal.sol b/contracts/interfaces/IERC2981Internal.sol
@@ -6,5 +6,5 @@ pragma solidity ^0.8.8;
  * @title ERC2981 interface
  */
 interface IERC2981Internal {
-    error ERC2981Internal__RoyaltyExceedsMax();
+
 }
diff --git a/contracts/token/common/ERC2981/ERC2981Internal.sol b/contracts/token/common/ERC2981/ERC2981Internal.sol
@@ -23,7 +23,6 @@ abstract contract ERC2981Internal is IERC2981Internal {
         returns (address royaltyReceiver, uint256 royalty)
     {
         uint256 royaltyBPS = _getRoyaltyBPS(tokenId);
-        if (royaltyBPS > 10000) revert ERC2981Internal__RoyaltyExceedsMax();
 
         // intermediate multiplication overflow is theoretically possible here, but
         // not an issue in practice because of practical constraints of salePrice
diff --git a/spec/token/common/ERC2981.behavior.ts b/spec/token/common/ERC2981.behavior.ts
@@ -34,17 +34,6 @@ export function describeBehaviorOfERC2981(
     );
 
     describe('#royaltyInfo()', () => {
-      describe('reverts if', () => {
-        it('royalty exceeds maximum', async function () {
-          await expect(
-            instance.royaltyInfo(tokenIdThree, ethers.constants.One),
-          ).to.be.revertedWithCustomError(
-            instance,
-            'ERC2981Internal__RoyaltyExceedsMax',
-          );
-        });
-      });
-
       it('returns 0 if salePrice is 0', async function () {
         const [, royaltyAmount] = await instance.royaltyInfo(
           0,

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,4 @@`
`1`	`1`	`[`
`2`		`- {`
`3`		`- "inputs": [],`
`4`		`- "name": "ERC2981Internal__RoyaltyExceedsMax",`
`5`		`- "type": "error"`
`6`		`- },`
`7`	`2`	`{`
`8`	`3`	`"inputs": [`
`9`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,5 @@ pragma solidity ^0.8.8;`
`6`	`6`	`* @title ERC2981 interface`
`7`	`7`	`*/`
`8`	`8`	`interface IERC2981Internal {`
`9`		`- error ERC2981Internal__RoyaltyExceedsMax();`
	`9`	`+`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,6 @@ abstract contract ERC2981Internal is IERC2981Internal {`
`23`	`23`	`returns (address royaltyReceiver, uint256 royalty)`
`24`	`24`	`{`
`25`	`25`	`uint256 royaltyBPS = _getRoyaltyBPS(tokenId);`
`26`		`- if (royaltyBPS > 10000) revert ERC2981Internal__RoyaltyExceedsMax();`
`27`	`26`
`28`	`27`	`// intermediate multiplication overflow is theoretically possible here, but`
`29`	`28`	`// not an issue in practice because of practical constraints of salePrice`