add overflow comment

ItsNickBarry · ItsNickBarry · commit b93171bdcfbc · 2022-10-20T22:12:17.000-05:00
diff --git a/contracts/token/common/ERC2981/ERC2981Internal.sol b/contracts/token/common/ERC2981/ERC2981Internal.sol
@@ -24,6 +24,9 @@ abstract contract ERC2981Internal is IERC2981Internal {
     {
         uint256 royaltyBPS = _getRoyaltyBPS(tokenId);
         if (royaltyBPS > 10000) revert ERC2981Internal__RoyaltyExceedsMax();
+
+        // intermediate multiplication overflow is theoretically possible here, but
+        // not an issue in practice because of practical constraints of salePrice
         return (_getRoyaltyReceiver(tokenId), (royaltyBPS * salePrice) / 10000);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,9 @@ abstract contract ERC2981Internal is IERC2981Internal {`
`24`	`24`	`{`
`25`	`25`	`uint256 royaltyBPS = _getRoyaltyBPS(tokenId);`
`26`	`26`	`if (royaltyBPS > 10000) revert ERC2981Internal__RoyaltyExceedsMax();`
	`27`	`+`
	`28`	`+ // intermediate multiplication overflow is theoretically possible here, but`
	`29`	`+ // not an issue in practice because of practical constraints of salePrice`
`27`	`30`	`return (_getRoyaltyReceiver(tokenId), (royaltyBPS * salePrice) / 10000);`
`28`	`31`	`}`
`29`	`32`