From 6faee34c847fdb1b0193321d727830ecc0d5bcc8 Mon Sep 17 00:00:00 2001 From: Alistair Norman Date: Thu, 28 Aug 2025 15:39:58 -0700 Subject: [PATCH 1/3] Update rspec-rails versions These versions were very old. Version 5.x is for Rails 5.2 and 6.x. 7.0 was removed from our CI tests so these are much older than we are testing. We added Rails 8 to the CI tests which means we should be using rspec-rails 8.x. --- solidus_dev_support.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solidus_dev_support.gemspec b/solidus_dev_support.gemspec index f884c69..0e800cb 100644 --- a/solidus_dev_support.gemspec +++ b/solidus_dev_support.gemspec @@ -39,7 +39,7 @@ Gem::Specification.new do |spec| spec.add_dependency "github_changelog_generator", "~> 1.15" spec.add_dependency "puma", ">= 4.3", "< 7.0" spec.add_dependency "rspec_junit_formatter" - spec.add_dependency "rspec-rails", ">= 5.0", "< 7.0" + spec.add_dependency "rspec-rails", ">= 6.0", "< 9.0" spec.add_dependency "selenium-webdriver", "~> 4.11" spec.add_dependency "simplecov-cobertura", "~> 2.1" spec.add_dependency "solidus_core", [">= 2.0", "< 5"] From 7020bf562449af0e2941dab64491dc4ef14c434e Mon Sep 17 00:00:00 2001 From: Alistair Norman Date: Fri, 5 Sep 2025 15:18:04 -0700 Subject: [PATCH 2/3] Fix tests locally If Rails isn't installed locally then this will fail. --- lib/solidus_dev_support/templates/extension/bin/sandbox.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/solidus_dev_support/templates/extension/bin/sandbox.tt b/lib/solidus_dev_support/templates/extension/bin/sandbox.tt index 7aa2f39..809ac3b 100755 --- a/lib/solidus_dev_support/templates/extension/bin/sandbox.tt +++ b/lib/solidus_dev_support/templates/extension/bin/sandbox.tt @@ -31,7 +31,7 @@ rm -rf ./sandbox echo "~~~> Creating a pristine Rails app" rails_version=`bundle exec ruby -e'require "rails"; puts Rails.version'` -rails _${rails_version}_ new sandbox \ +unbundled bundle exec rails _${rails_version}_ new sandbox \ --database="${DB:-sqlite3}" \ --skip-git \ --skip-keeps \ From 4ae946ae7e2bf7ed090ef569ba52530e0416abd0 Mon Sep 17 00:00:00 2001 From: Alistair Norman Date: Fri, 5 Sep 2025 15:32:27 -0700 Subject: [PATCH 3/3] Remove expectation This text is no longer outputted because we pass in the quiet flag and as of the commit linked below, we no longer use puts which previously ignored that flag. https://github.com/solidusio/solidus/commit/0a0313aca78bf7bc19029aa1ac79c2d3552e7c3e --- spec/features/create_extension_spec.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/spec/features/create_extension_spec.rb b/spec/features/create_extension_spec.rb index 8cda7e0..f47eb03 100644 --- a/spec/features/create_extension_spec.rb +++ b/spec/features/create_extension_spec.rb @@ -114,7 +114,6 @@ def check_bundle_install def check_default_task cd(install_path) do output = sh("bin/rake") - expect(output).to include("Generating dummy Rails application") expect(output).to include("0 examples, 0 failures") end end