code_style: add extension methods WalkFiles and GetRelativePath for DirectoryInfo

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/App.Extensions.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 
 namespace SourceGit
 {
@@ -23,4 +24,24 @@ public static T Use<T>(this T cmd, Models.ICommandLog log) where T : Commands.Co
             return cmd;
         }
     }
+
+    public static class DirectoryInfoExtension
+    {
+        public static void WalkFiles(this DirectoryInfo dir, Action<string> onFile, int maxDepth = 4)
+        {
+            foreach (var file in dir.GetFiles())
+                onFile(file.FullName);
+
+            if (maxDepth > 0)
+            {
+                foreach (var subDir in dir.GetDirectories())
+                    WalkFiles(subDir, onFile, maxDepth - 1);
+            }
+        }
+
+        public static string GetRelativePath(this DirectoryInfo dir, string fullpath)
+        {
+            return fullpath.Substring(dir.FullName.Length).TrimStart(Path.DirectorySeparatorChar);
+        }
+    }
 }

src/Models/ExternalTool.cs

@@ -225,27 +225,16 @@ public void FindJetBrainsFromToolbox(Func<string> platformFinder)
 
         private List<ExternalTool.LaunchOption> GenerateVSCodeLaunchOptions(string path)
         {
-            if (!Directory.Exists(path))
+            var root = new DirectoryInfo(path);
+            if (!root.Exists)
                 return null;
 
-            void Search(List<ExternalTool.LaunchOption> opts, DirectoryInfo dir, string root, int depth)
-            {
-                if (depth < 0)
-                    return;
-
-                foreach (var file in dir.GetFiles())
-                {
-                    if (file.Name.EndsWith(".code-workspace", StringComparison.OrdinalIgnoreCase))
-                        opts.Add(new(Path.GetRelativePath(root, file.FullName), file.FullName.Quoted()));
-                }
-
-                foreach (var subDir in dir.GetDirectories())
-                    Search(opts, subDir, root, depth - 1);
-            }
-
-            var rootDir = new DirectoryInfo(path);
             var options = new List<ExternalTool.LaunchOption>();
-            Search(options, rootDir, rootDir.FullName, 4);
+            root.WalkFiles(f =>
+            {
+                if (f.EndsWith(".code-workspace", StringComparison.OrdinalIgnoreCase))
+                    options.Add(new(root.GetRelativePath(f), f.Quoted()));
+            });
             return options;
         }
 

src/Native/Windows.cs

@@ -458,32 +458,18 @@ private void OpenFolderAndSelectFile(string folderPath)
 
         private List<Models.ExternalTool.LaunchOption> GenerateVSProjectLaunchOptions(string path)
         {
-            if (Directory.Exists(path))
-            {
-                void Search(List<Models.ExternalTool.LaunchOption> opts, DirectoryInfo dir, string root, int depth)
-                {
-                    if (depth < 0)
-                        return;
-
-                    foreach (var file in dir.GetFiles())
-                    {
-                        if (file.Name.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||
-                            file.Name.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))
-                            opts.Add(new(Path.GetRelativePath(root, file.FullName), file.FullName.Quoted()));
-                    }
-
-                    foreach (var subDir in dir.GetDirectories())
-                        Search(opts, subDir, root, depth - 1);
-                }
-
-                var rootDir = new DirectoryInfo(path);
-                var options = new List<Models.ExternalTool.LaunchOption>();
-                Search(options, rootDir, rootDir.FullName, 4);
-                if (options.Count > 0)
-                    return options;
-            }
+            var root = new DirectoryInfo(path);
+            if (!root.Exists)
+                return null;
 
-            return null;
+            var options = new List<Models.ExternalTool.LaunchOption>();
+            root.WalkFiles(f =>
+            {
+                if (f.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||
+                    f.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))
+                    options.Add(new(root.GetRelativePath(f), f.Quoted()));
+            });
+            return options;
         }
     }
 }