gitserver: change the way repo name is checked for git command recording. (#55111)

Previously, we checked for a substring, but it breaks in cases where
given repo name is a prefix for another repo names, e.g.: "repo/a" is
included, but "repo/ab" and "repo/a-1" are included too, because of the
check.

This commit changes this behaviour to check for the suffix instead,
which is not perfect, but judging from local testing and how the repos
are named ("orgName/repoName"), this check will filter out most repos
which were previously included by mistake.

Precise implementation requires a lot of effort to propagate repo names
through the recording stack and can be done later.

Test plan:
Local sg run and test that repos with matching prefix are not recorded.

Author: sashaostrikov

cmd/gitserver/shared/shared.go

@@ -641,7 +641,11 @@ func recordCommandsOnRepos(repos []string) wrexec.ShouldRecordFunc {
 
 		repoMatch := false
 		for _, repo := range repos {
-			if strings.Contains(cmd.Dir, repo) {
+			// We need to check the suffix, because we can have some common parts in
+			// different repo names. E.g. "sourcegraph/sourcegraph" and
+			// "sourcegraph/sourcegraph-code-ownership" will both be allowed even if only the
+			// first name is included in the config.
+			if strings.HasSuffix(cmd.Dir, repo+"/.git") {
 				repoMatch = true
 				break
 			}

internal/wrexec/recording_cmd.go

@@ -36,7 +36,7 @@ type RecordingCmd struct {
 	done         bool
 }
 
-// ShouldRecordFunc is a predicate to signifiy if a command should be recorded or just pass through.
+// ShouldRecordFunc is a predicate to signify if a command should be recorded or just pass through.
 type ShouldRecordFunc func(context.Context, *exec.Cmd) bool
 
 // RecordingCommand contructs a RecordingCommand that implements Cmder. The predicate shouldRecord can be passed to decide on whether