Skip to content

Commit 27d1e3b

Browse files
committed
Added dedupe logic
1 parent e2c9cfd commit 27d1e3b

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

client/src/main/java/io/split/client/impressions/strategy/ProcessImpressionDebug.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ public ProcessImpressionDebug(boolean listenerEnabled, ImpressionObserver impres
1919
@Override
2020
public ImpressionsResult process(List<Impression> impressions) {
2121
for(Impression impression : impressions) {
22+
if (impression.properties() != null) {
23+
continue;
24+
}
2225
impression.withPreviousTime(_impressionObserver.testAndSet(impression));
2326
}
2427
List<Impression> impressionForListener = this._listenerEnabled ? impressions : null;

client/src/main/java/io/split/client/impressions/strategy/ProcessImpressionOptimized.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ public ProcessImpressionOptimized(boolean listenerEnabled, ImpressionObserver im
3232
public ImpressionsResult process(List<Impression> impressions) {
3333
List<Impression> impressionsToQueue = new ArrayList<>();
3434
for(Impression impression : impressions) {
35+
if (impression.properties() != null) {
36+
continue;
37+
}
3538
impression = impression.withPreviousTime(_impressionObserver.testAndSet(impression));
3639
if(!Objects.isNull(impression.pt()) && impression.pt() != 0){
3740
_impressionCounter.inc(impression.split(), impression.time(), 1);

0 commit comments

Comments
 (0)