Skip to content

Commit 58a5be5

Browse files
committed
added getSegmentNames method
1 parent 6b51bcb commit 58a5be5

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

client/src/main/java/io/split/engine/segments/SegmentSynchronizationTaskImp.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@
1111
import org.slf4j.LoggerFactory;
1212

1313
import java.io.Closeable;
14+
import java.util.HashSet;
1415
import java.util.List;
1516
import java.util.Map;
17+
import java.util.Set;
1618
import java.util.concurrent.ConcurrentMap;
1719
import java.util.concurrent.ExecutionException;
1820
import java.util.concurrent.Future;
@@ -198,4 +200,11 @@ private void initialize(String segmentName) {
198200
_segmentFetchers.putIfAbsent(segmentName, segment);
199201
}
200202
}
203+
204+
private Set<String> getSegmentNames() {
205+
Set<String> names = new HashSet<>(_splitCacheConsumer.getSegments());
206+
names.addAll(_ruleBasedSegmentCacheConsumer.getSegments());
207+
208+
return names;
209+
}
201210
}

client/src/main/java/io/split/engine/sse/NotificationProcessorImp.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package io.split.engine.sse;
22

33
import com.google.common.annotations.VisibleForTesting;
4+
import io.split.client.dtos.Split;
45
import io.split.engine.sse.dtos.GenericNotificationData;
56
import io.split.engine.sse.dtos.IncomingNotification;
67
import io.split.engine.sse.dtos.SplitKillNotification;
78
import io.split.engine.sse.dtos.StatusNotification;
89
import io.split.engine.sse.dtos.SegmentQueueDto;
10+
import io.split.engine.sse.dtos.CommonChangeNotification;
911
import io.split.engine.sse.workers.FeatureFlagsWorker;
1012
import io.split.engine.sse.workers.Worker;
1113

@@ -42,10 +44,10 @@ public void process(IncomingNotification notification) {
4244
@Override
4345
public void processSplitKill(SplitKillNotification splitKillNotification) {
4446
_featureFlagsWorker.kill(splitKillNotification);
45-
_featureFlagsWorker.addToQueue(new SplitKillNotification(GenericNotificationData.builder()
47+
_featureFlagsWorker.addToQueue(new CommonChangeNotification<>(GenericNotificationData.builder()
4648
.changeNumber(splitKillNotification.getChangeNumber())
4749
.channel(splitKillNotification.getChannel())
48-
.build()));
50+
.build(), Split.class));
4951
}
5052

5153
@Override

0 commit comments

Comments
 (0)