Merge pull request #434 from splitio/asynctask/suggestions

fix tests

Author: chillaq

splitio/tasks/util/asynctask.py

@@ -218,8 +218,7 @@ def __init__(self, main, period, on_init=None, on_stop=None):
         self._period = period
         self._messages = asyncio.Queue()
         self._running = False
-        self._task = None
-        self._stop_event = None
+        self._completion_event = None
 
     async def _execution_wrapper(self):
         """
@@ -286,7 +285,7 @@ def start(self):
             return
         # Start execution
         self._completion_event = asyncio.Event()
-        self._task = asyncio.get_running_loop().create_task(self._execution_wrapper())
+        asyncio.get_running_loop().create_task(self._execution_wrapper())
 
     async def stop(self, wait_for_completion=False):
         """

tests/tasks/util/test_asynctask.py

@@ -142,7 +142,7 @@ async def on_stop():
         task.start()
         await asyncio.sleep(1)
         assert task.running()
-        await task.stop()
+        await task.stop(True)
 
         assert 0 < self.main_called <= 2
         assert self.init_called == 1
@@ -170,7 +170,7 @@ async def on_stop():
         task.start()
         await asyncio.sleep(1)
         assert task.running()
-        await task.stop()
+        await task.stop(True)
 
         assert 9 <= self.main_called <= 10
         assert self.init_called == 1
@@ -197,7 +197,7 @@ async def on_stop():
         task.start()
         await asyncio.sleep(0.5)
         assert not task.running() # Since on_init fails, task never starts
-        await task.stop()
+        await task.stop(True)
 
         assert self.init_called == 1
         assert self.stop_called == 1
@@ -223,7 +223,7 @@ async def on_stop():
         task = asynctask.AsyncTaskAsync(main_func, 0.1, on_init, on_stop)
         task.start()
         await asyncio.sleep(1)
-        await task.stop()
+        await task.stop(True)
         assert 9 <= self.main_called <= 10
         assert self.init_called == 1
         assert self.stop_called == 1
@@ -249,7 +249,7 @@ async def on_stop():
         assert task.running()
         task.force_execution()
         task.force_execution()
-        await task.stop()
+        await task.stop(True)
 
         assert self.main_called == 3
         assert self.init_called == 1