Skip to content

Commit 11d56fd

Browse files
chillaqchillaq
committed
fixed typo for segment update type
1 parent 4327a30 commit 11d56fd

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎splitio/events/events_metadata.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class SdkEventType(Enum):
55
"""Public event types"""
66

77
FLAG_UPDATE = 'FLAG_UPDATE'
8-
SEGMENT_UPDATE = 'SEGMENT_UPDATE'
8+
SEGMENTS_UPDATE = 'SEGMENTS_UPDATE'
99

1010
class EventsMetadata(object):
1111
"""Events Metadata class."""

‎splitio/storage/inmemmory.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def update(self, to_add, to_delete, new_change_number):
158158
self._internal_event_queue.put(
159159
SdkInternalEventNotification(
160160
SdkInternalEvent.RB_SEGMENTS_UPDATED,
161-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
161+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
162162

163163
def _put(self, rule_based_segment):
164164
"""
@@ -290,7 +290,7 @@ async def update(self, to_add, to_delete, new_change_number):
290290
await self._internal_event_queue.put(
291291
SdkInternalEventNotification(
292292
SdkInternalEvent.RB_SEGMENTS_UPDATED,
293-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
293+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
294294

295295
async def _put(self, rule_based_segment):
296296
"""
@@ -999,7 +999,7 @@ def put(self, segment):
999999
self._internal_event_queue.put(
10001000
SdkInternalEventNotification(
10011001
SdkInternalEvent.SEGMENTS_UPDATED,
1002-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
1002+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
10031003

10041004
def update(self, segment_name, to_add, to_remove, change_number=None):
10051005
"""
@@ -1025,7 +1025,7 @@ def update(self, segment_name, to_add, to_remove, change_number=None):
10251025
self._internal_event_queue.put(
10261026
SdkInternalEventNotification(
10271027
SdkInternalEvent.SEGMENTS_UPDATED,
1028-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
1028+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
10291029

10301030
def get_change_number(self, segment_name):
10311031
"""
@@ -1140,7 +1140,7 @@ async def put(self, segment):
11401140
await self._internal_event_queue.put(
11411141
SdkInternalEventNotification(
11421142
SdkInternalEvent.SEGMENTS_UPDATED,
1143-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
1143+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
11441144

11451145

11461146
async def update(self, segment_name, to_add, to_remove, change_number=None):
@@ -1166,7 +1166,7 @@ async def update(self, segment_name, to_add, to_remove, change_number=None):
11661166
await self._internal_event_queue.put(
11671167
SdkInternalEventNotification(
11681168
SdkInternalEvent.SEGMENTS_UPDATED,
1169-
EventsMetadata(SdkEventType.SEGMENT_UPDATE, {})))
1169+
EventsMetadata(SdkEventType.SEGMENTS_UPDATE, {})))
11701170

11711171

11721172
async def get_change_number(self, segment_name):

‎tests/integration/test_streaming_e2e.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def test_happiness(self):
128128
sse_server.publish(make_segment_change_event('segment1', 1))
129129
time.sleep(1)
130130
assert self.update_flag
131-
assert self.metadata[len(self.metadata)-1].get_type() == SdkEventType.SEGMENT_UPDATE
131+
assert self.metadata[len(self.metadata)-1].get_type() == SdkEventType.SEGMENTS_UPDATE
132132
flag = False
133133
for meta in self.metadata:
134134
if 'split2' in meta.get_names():

‎tests/storage/test_inmemory_storage.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -811,13 +811,13 @@ def test_internal_event_notification(self):
811811
storage.put(segment)
812812
event = events_queue.get()
813813
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
814-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
814+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
815815
assert len(event.metadata.get_names()) == 0
816816

817817
storage.update('some_segment', ['key4', 'key5'], ['key2', 'key3'], 456)
818818
event = events_queue.get()
819819
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
820-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
820+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
821821
assert len(event.metadata.get_names()) == 0
822822

823823
class InMemorySegmentStorageAsyncTests(object):
@@ -893,13 +893,13 @@ async def test_internal_event_notification(self):
893893
await storage.put(segment)
894894
event = await events_queue.get()
895895
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
896-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
896+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
897897
assert len(event.metadata.get_names()) == 0
898898

899899
await storage.update('some_segment', ['key4', 'key5'], ['key2', 'key3'], 456)
900900
event = await events_queue.get()
901901
assert event.internal_event == SdkInternalEvent.SEGMENTS_UPDATED
902-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
902+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
903903
assert len(event.metadata.get_names()) == 0
904904

905905
class InMemoryImpressionsStorageTests(object):
@@ -2006,12 +2006,12 @@ def test_internal_event_notification(self, mocker):
20062006
rbs_storage.update([segment1, segment2], [], -1)
20072007
event = events_queue.get()
20082008
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
2009-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
2009+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
20102010
assert len(event.metadata.get_names()) == 0
20112011

20122012
rbs_storage.update([], ['some_segment'], -1)
20132013
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
2014-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
2014+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
20152015
assert len(event.metadata.get_names()) == 0
20162016

20172017
class InMemoryRuleBasedSegmentStorageAsyncTests(object):
@@ -2093,12 +2093,12 @@ async def test_internal_event_notification(self, mocker):
20932093
await rbs_storage.update([segment1, segment2], [], -1)
20942094
event = await events_queue.get()
20952095
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
2096-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
2096+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
20972097
assert len(event.metadata.get_names()) == 0
20982098

20992099
await rbs_storage.update([], ['some_segment'], -1)
21002100
event = await events_queue.get()
21012101
assert event.internal_event == SdkInternalEvent.RB_SEGMENTS_UPDATED
2102-
assert event.metadata.get_type() == SdkEventType.SEGMENT_UPDATE
2102+
assert event.metadata.get_type() == SdkEventType.SEGMENTS_UPDATE
21032103
assert len(event.metadata.get_names()) == 0
21042104

0 commit comments

Comments
 (0)